Add ntracks associated to each SV

[gouskos]

PR description:

Add the number of tracks associated to each SV
Necessary for the soft b-tagging algorithm developed int the context of SUS-16-049 and is been used in multiple other analyses [e.g., SUS-16-032, SUS-19-009, SUS-19-010, HIG-18-026,..]

Also: Necessary for the calibration of the bb/cc component of various boosted jet taggers [e.g, DeepAK8/DeepAK15/ParticleNet..]

PR validation:

produced a test file:
cmsDriver.py test_nanoTuples_mc2017 -n 10 --mc --eventcontent NANOAODSIM --datatier NANOAODSIM --conditions auto:phase1_2017_realistic --step NANO --nThreads 1 --era Run2_2017,run2_nanoAOD_106Xv1 --filein /store/mc/RunIISummer19UL17MiniAOD/TTToSemiLeptonic_TuneCP5CR2_13TeV-powheg-pythia8/MINIAODSIM/106X_mc2017_realistic_v6-v1/10000/466694A9-3806-624C-87A0-97C8379FAD23.root --fileout file:nano_mc2017.root --customise_commands "process.options.wantSummary = cms.untracked.bool(True)"

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31696/18852

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @gouskos for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

+xpog

The PR adds the number of tracks associated to each SV.
a backport in 106X will follow.

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10015/console Started: 2020/10/16 12:27

[cmsbuild]

+1
Tested at: f4ce583
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0a86/10015/summary.html
CMSSW: CMSSW_11_2_X_2020-10-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0a86/10015/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 19 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543717
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.079 KiB( 34 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 0.079 KiB Physics/NanoAODDQM
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cmsbuild]

Pull request #31696 was updated. @cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[gouskos]

please test workflow 10224.15, 11024.15, 25202.15

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 11024.15,10224.15,25202.15
• CMSSW_11_2_X_2020-10-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10030/console Started: 2020/10/16 17:59

[mariadalfonso]

I think we see this kind of differences in nanoaodFlatTable every time we add a new variable in NanoAOD. @peruzzim @mariadalfonso @cms-sw/reconstruction-l2 do you confirm this?

@gouskos you can proceed with the update of the PR. The test results should remain there.

@silviodonato
yes the plot from cms-sw testing are made with indices, so when a new variable is added they get out of synch, see Slava comment back in august #31077 (comment)

We test the PR from central nano with gitlab-nanoAOD-integration we inherit from Andrea/Giovanni and recently updated by Marco and use the standard DQM for the plots and we monitor changes in variable content size and cpu timing.

For the jme-nano we only check if the workflow crash.

[cmsbuild]

+1
Tested at: 3888fe7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0a86/10030/summary.html
CMSSW: CMSSW_11_2_X_2020-10-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0a86/10030/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aa0a86/10224.15_TTbar_13+2017PU_JMENano+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aa0a86/11024.15_TTbar_13+2018PU_JMENano+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aa0a86/25202.15_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543729
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.079 KiB( 34 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 0.079 KiB Physics/NanoAODDQM
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[silviodonato]

+1

[santocch]

+1

[silviodonato]

@cms-sw/xpog-l2 can we merge this?

[gouskos]

+xpog
Yes @silviodonato

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.