Updates for CSC L1T DQM following B904 tests on cosmic data

[dildick]

PR description:

Updates for CSC L1T DQM following B904 tests on cosmic data. DQM modules in L1TMonitor and L1TMonitorClient were given an option so that we can analyze data from the B904 test-stand. Data-vs-emulation is a 5-step procedure. The last step produces a single postscript containing histograms with data-vs-emulator comparisons.

## step 1: get the .raw file from the CSC DAQ computer. Contact B904 experts

## step 2: convert the .raw file to EDM ROOT. Set firstRun high enough so that the GEM geometry is recognized in Run-3 eras in step 3.
cmsRun IORawData/CSCCommissioning/test/readFile_b904_Run3.py firstRun=341761 \
inputFiles=csc_00000001_EmuRUI01_Local_000_210519_162820_UTC.raw maxEvents=80000

## step 3: unpack, emulate, and run the DQM
cmsRun L1Trigger/CSCTriggerPrimitives/test/runCSCTriggerPrimitiveProducer_cfg.py unpack=True l1=True dqm=True \
runCCLUT=True runME11ILT=False useB904Data=True maxEvents=-1 \
inputFiles= csc_00000001_EmuRUI01_Local_000_210519_162820_UTC.root 

## step 4: run the DQM client (produces histograms of differences)
cmsRun L1Trigger/CSCTriggerPrimitives/test/runCSCL1TDQMClient_cfg.py mc=False run3=True useB904Data=True

## step 5: run the L1 CSC analyzer (run number 341761 is set in step 2). Produces a postscript file.
cmsRun L1Trigger/CSCTriggerPrimitives/test/runCSCTriggerPrimitiveAnalyzer_cfg.py dataVsEmulation=True \
dataVsEmulationFile=file:DQM_V0001_R000341761__Global__CMSSW_X_Y_Z__RECO.root runNumber=341761

Note that the CSC unpacker in CMSSW for Run-3 data is not yet updated. That is expected to happen in the next few weeks/months. The validation plots were made with the Run-3 unpacker in a private branch.

PR validation:

Tested with

scram b -k -j 16 runtests
runTheMatrix.py -l limited

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport needed I think. Most of our CSC trigger primitive tests are being conducted with the B904 test-stand. Depending on the timeline when the CSC firmware will be updated at P5 (before or during CRUZET, before or during CRAFT?) it may need to be backported. Perhaps by then we will have switched to CMSSW_12_0_0 at P5.

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@barvic @tahuang1991

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33876/22910

ERROR: Build errors found during clang-tidy run.

                                                                    getEighthStrip
--
DQM/L1TMonitor/src/L1TdeCSCTPG.cc:191:66: error: no member named 'getQuartStripBit' in 'CSCCorrelatedLCTDigi'; did you mean 'getQuartStrip'? [clang-diagnostic-error]
        chamberHistos[type]["lct_quartstripbit_data"]->Fill(lct->getQuartStripBit());
                                                                 ^~~~~~~~~~~~~~~~
                                                                 getQuartStrip
--
DQM/L1TMonitor/src/L1TdeCSCTPG.cc:192:67: error: no member named 'getEighthStripBit' in 'CSCCorrelatedLCTDigi'; did you mean 'getEighthStrip'? [clang-diagnostic-error]
        chamberHistos[type]["lct_eighthstripbit_data"]->Fill(lct->getEighthStripBit());
                                                                  ^~~~~~~~~~~~~~~~~
                                                                  getEighthStrip
--
DQM/L1TMonitor/src/L1TdeCSCTPG.cc:214:66: error: no member named 'getQuartStripBit' in 'CSCCorrelatedLCTDigi'; did you mean 'getQuartStrip'? [clang-diagnostic-error]
        chamberHistos[type]["lct_quartstripbit_emul"]->Fill(lct->getQuartStripBit());
                                                                 ^~~~~~~~~~~~~~~~
                                                                 getQuartStrip
--
DQM/L1TMonitor/src/L1TdeCSCTPG.cc:215:67: error: no member named 'getEighthStripBit' in 'CSCCorrelatedLCTDigi'; did you mean 'getEighthStrip'? [clang-diagnostic-error]
        chamberHistos[type]["lct_eighthstripbit_emul"]->Fill(lct->getEighthStripBit());
                                                                  ^~~~~~~~~~~~~~~~~
                                                                  getEighthStrip
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[dildick]

A few plots from the postscript file with just 1000 events from the May 19 B904 cosmic run below. (There are actually 80,000 events in total). There are discrepancies, but at least the procedure works as expected.

• ALCT properties look in general very good.
• Many discrepancies for CLCT and LCT due to (1) wrong parity of the OTMB firmware version loaded onto FPGA and (2) private version of CSC unpacker needs updates for Run-3 CSC TPs. We understand the issues and are planning a new cosmic run next week.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33876/22921

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
DataFormats/MuonDetId
EventFilter/CSCRawToDigi
IORawData/CSCCommissioning
L1Trigger/CSCTriggerPrimitives

@perrotta, @civanch, @kmaeshima, @smorovic, @emeschi, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @ahmad3213, @slava77, @jpata, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic, @HuguesBrun, @battibass, @abbiendi, @Fedespring, @valuev, @calderona, @sscruz, @jhgoh, @ptcox, @rovere, @trocino, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33876/22922

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #33876 was updated. @perrotta, @civanch, @kmaeshima, @smorovic, @emeschi, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @ahmad3213, @slava77, @jpata, @cecilecaillol, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68600a/15626/summary.html
COMMIT: 093bbf1
CMSSW: CMSSW_12_0_X_2021-06-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33876/15626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2646502
• DQMHistoTests: Total failures: 80
• DQMHistoTests: Total nulls: 371
• DQMHistoTests: Total successes: 2646029
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1559.295 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -39.473 KiB L1TEMU/L1TdeCSCTPG
• DQMHistoSizes: changed ( 10024.0,... ): 65.138 KiB L1TEMU/L1TdeCSCTPG
• DQMHistoSizes: changed ( 11634.0,... ): 311.645 KiB L1TEMU/L1TdeCSCTPG
• DQMHistoSizes: changed ( 136.731 ): 0.600 KiB L1TEMU/L1TdeCSCTPG
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[smorovic]

+1

[jfernan2]

+1

[civanch]

+1

[slava77]

+reconstruction

for #33876 093bbf1

• code changes in reco are limited to a test config in EventFilter/CSCRawToDigi/test/testCSCDigi2Raw_cfg.py
• jenkins tests pass and comparisons with the baseline show no relevant differences in reco quantities (there are some diffs in L1TEMU)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1