-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: nano: adaptation to run in Prompt #34329
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34329/23680
|
A new Pull Request was created by @mariadalfonso for master. It involves the following packages: Configuration/Eras @gouskos, @silviodonato, @fabiocos, @cmsbuild, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test 546,547,548 (nanoGen workflows) |
please test workflow 546.0,547.0,548.0 |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsNanoAOD had ERRORS RelVals
RelVals-INPUT
|
Pull request #34329 was updated. @gouskos, @silviodonato, @fabiocos, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please check and sign again. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
status so far :)
once I fix this jet, I move all the non ele/ph/met in a separate PR that can be merged right away w.o breaking anything |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34329/24223
|
Pull request #34329 was updated. @gouskos, @silviodonato, @fabiocos, @cmsbuild, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
I close this, given that has been splitted in 3 smaller PRs |
This draft PR: attempt to update the nano sequence to run together with mini (reco + DQM)
very long list of modules with order problems here ~ http://dalfonso.web.cern.ch/dalfonso/orderingModulesNano.txt)
For the moment: photon/electron//METrecalibration are dummy
These objects recycle sequence used for miniAOD called from inside the nano_cff.py
I will need to follow with EGM/JME POGS
run3_nanoAOD_devel at the end should not be used as the master version should be able to run straigh on the newer nano.
TESTED so far:
nanoGen (porting complete) wf 546 works
106Xv2 (i.e. nanoV9) wf 136.8523 runs
cmsDriver.py step3 --conditions auto:phase1_2021_realistic -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --geometry DB:Extended --era Run3,run3_nanoAOD_devel --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --filein file:step2.root --fileout file:step3.root
runs with step2 from wf 11634.0
previous eras fails tested because of the shortcut in photon/electron/tau/boostedtau/METrecalibration
136.8521 (102Xv1)
136.7952 (94Xv2)
JMEnano will stop working:
JME sequences too customs and need to by updated by JME
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/custom_jme_cff.py