Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: nano: adaptation to run in Prompt #34329

Closed
wants to merge 20 commits into from

Conversation

mariadalfonso
Copy link
Contributor

@mariadalfonso mariadalfonso commented Jul 4, 2021

This draft PR: attempt to update the nano sequence to run together with mini (reco + DQM)

For the moment: photon/electron//METrecalibration are dummy
These objects recycle sequence used for miniAOD called from inside the nano_cff.py
I will need to follow with EGM/JME POGS
run3_nanoAOD_devel at the end should not be used as the master version should be able to run straigh on the newer nano.

TESTED so far:

  1. nanoGen (porting complete) wf 546 works

  2. 106Xv2 (i.e. nanoV9) wf 136.8523 runs

  3. cmsDriver.py step3 --conditions auto:phase1_2021_realistic -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --geometry DB:Extended --era Run3,run3_nanoAOD_devel --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --filein file:step2.root --fileout file:step3.root

runs with step2 from wf 11634.0

  1. previous eras fails tested because of the shortcut in photon/electron/tau/boostedtau/METrecalibration
    136.8521 (102Xv1)
    136.7952 (94Xv2)

  2. JMEnano will stop working:
    JME sequences too customs and need to by updated by JME
    https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/custom_jme_cff.py

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Jul 4, 2021
@mariadalfonso mariadalfonso changed the title nano: adaptation to run in Prompt DRAFT: nano: adaptation to run in Prompt Jul 4, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34329/23680

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
PhysicsTools/NanoAOD

@gouskos, @silviodonato, @fabiocos, @cmsbuild, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please review it and eventually sign? Thanks.
@mtosi, @fabiocos, @swertz, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @gpetruc, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor Author

please test 546,547,548

(nanoGen workflows)

@smuzaffar
Copy link
Contributor

please test workflow 546.0,547.0,548.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2021

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be3056/16453/summary.html
COMMIT: f0a659d
CMSSW: CMSSW_12_0_X_2021-07-04-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34329/16453/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

----- Begin Fatal Exception 04-Jul-2021 22:34:56 CEST-----------------------
An exception of category 'Key not found' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Prefetching for module BTagSFProducer/'btagWeightTable'
   [4] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [5] Calling method for module PATTauRefSelector/'finalTaus'
Exception Message:
pat::Tau: the ID byVVVLooseDeepTau2017v2p1VSjet can't be found in this pat::Tau.
The available IDs are: 'againstElectronLooseMVA6' 'againstElectronMVA6Raw' 'againstElectronMVA6category' 'againstElectronMediumMVA6' 'againstElectronTightMVA6' 'againstElectronVLooseMVA6' 'againstElectronVTightMVA6' 'againstMuonLoose3' 'againstMuonTight3' 'byCombinedIsolationDeltaBetaCorrRaw3Hits' 'byIsolationMVArun2v1DBdR03oldDMwLTraw' 'byIsolationMVArun2v1DBnewDMwLTraw' 'byIsolationMVArun2v1DBoldDMwLTraw' 'byIsolationMVArun2v1PWdR03oldDMwLTraw' 'byIsolationMVArun2v1PWnewDMwLTraw' 'byIsolationMVArun2v1PWoldDMwLTraw' 'byLooseCombinedIsolationDeltaBetaCorr3Hits' 'byLooseIsolationMVArun2v1DBdR03oldDMwLT' 'byLooseIsolationMVArun2v1DBnewDMwLT' 'byLooseIsolationMVArun2v1DBoldDMwLT' 'byLooseIsolationMVArun2v1PWdR03oldDMwLT' 'byLooseIsolationMVArun2v1PWnewDMwLT' 'byLooseIsolationMVArun2v1PWoldDMwLT' 'byMediumCombinedIsolationDeltaBetaCorr3Hits' 'byMediumIsolationMVArun2v1DBdR03oldDMwLT' 'byMediumIsolationMVArun2v1DBnewDMwLT' 'byMediumIsolationMVArun2v1DBoldDMwLT' 'byMediumIsolationMVArun2v1PWdR03oldDMwLT' 'byMediumIsolationMVArun2v1PWnewDMwLT' 'byMediumIsolationMVArun2v1PWoldDMwLT' 'byPhotonPtSumOutsideSignalCone' 'byTightCombinedIsolationDeltaBetaCorr3Hits' 'byTightIsolationMVArun2v1DBdR03oldDMwLT' 'byTightIsolationMVArun2v1DBnewDMwLT' 'byTightIsolationMVArun2v1DBoldDMwLT' 'byTightIsolationMVArun2v1PWdR03oldDMwLT' 'byTightIsolationMVArun2v1PWnewDMwLT' 'byTightIsolationMVArun2v1PWoldDMwLT' 'byVLooseIsolationMVArun2v1DBdR03oldDMwLT' 'byVLooseIsolationMVArun2v1DBnewDMwLT' 'byVLooseIsolationMVArun2v1DBoldDMwLT' 'byVLooseIsolationMVArun2v1PWdR03oldDMwLT' 'byVLooseIsolationMVArun2v1PWnewDMwLT' 'byVLooseIsolationMVArun2v1PWoldDMwLT' 'byVTightIsolationMVArun2v1DBdR03oldDMwLT' 'byVTightIsolationMVArun2v1DBnewDMwLT' 'byVTightIsolationMVArun2v1DBoldDMwLT' 'byVTightIsolationMVArun2v1PWdR03oldDMwLT' 'byVTightIsolationMVArun2v1PWnewDMwLT' 'byVTightIsolationMVArun2v1PWoldDMwLT' 'byVVLooseIsolationMVArun2v1DBdR03oldDMwLT' 'byVVLooseIsolationMVArun2v1DBnewDMwLT' 'byVVLooseIsolationMVArun2v1DBoldDMwLT' 'byVVTightIsolationMVArun2v1DBdR03oldDMwLT' 'byVVTightIsolationMVArun2v1DBnewDMwLT' 'byVVTightIsolationMVArun2v1DBoldDMwLT' 'byVVTightIsolationMVArun2v1PWdR03oldDMwLT' 'byVVTightIsolationMVArun2v1PWnewDMwLT' 'byVVTightIsolationMVArun2v1PWoldDMwLT' 'chargedIsoPtSum' 'chargedIsoPtSumdR03' 'decayModeFinding' 'decayModeFindingNewDMs' 'footprintCorrection' 'footprintCorrectiondR03' 'neutralIsoPtSum' 'neutralIsoPtSumWeight' 'neutralIsoPtSumWeightdR03' 'neutralIsoPtSumdR03' 'photonPtSumOutsideSignalCone' 'photonPtSumOutsideSignalConedR03' 'puCorrPtSum' 'byDeepTau2017v2VSeraw' 'byDeepTau2017v2VSjetraw' 'byDeepTau2017v2VSmuraw' 'byLooseDeepTau2017v2VSe' 'byLooseDeepTau2017v2VSjet' 'byLooseDeepTau2017v2VSmu' 'byMediumDeepTau2017v2VSe' 'byMediumDeepTau2017v2VSjet' 'byMediumDeepTau2017v2VSmu' 'byTightDeepTau2017v2VSe' 'byTightDeepTau2017v2VSjet' 'byTightDeepTau2017v2VSmu' 'byVLooseDeepTau2017v2VSe' 'byVLooseDeepTau2017v2VSjet' 'byVLooseDeepTau2017v2VSmu' 'byVTightDeepTau2017v2VSe' 'byVTightDeepTau2017v2VSjet' 'byVVLooseDeepTau2017v2VSe' 'byVVLooseDeepTau2017v2VSjet' 'byVVTightDeepTau2017v2VSe' 'byVVTightDeepTau2017v2VSjet' 'byVVVLooseDeepTau2017v2VSe' 'byVVVLooseDeepTau2017v2VSjet' 'againstElectronDeadECALForNano' 'againstElectronLooseMVA62018' 'againstElectronMVA6Raw2018' 'againstElectronMVA6category2018' 'againstElectronMediumMVA62018' 'againstElectronTightMVA62018' 'againstElectronVLooseMVA62018' 'againstElectronVTightMVA62018' 'byIsolationMVArun2v1DBnewDMwLTraw2017v2' 'byLooseIsolationMVArun2v1DBnewDMwLT2017v2' 'byMediumIsolationMVArun2v1DBnewDMwLT2017v2' 'byTightIsolationMVArun2v1DBnewDMwLT2017v2' 'byVLooseIsolationMVArun2v1DBnewDMwLT2017v2' 'byVTightIsolationMVArun2v1DBnewDMwLT2017v2' 'byVVLooseIsolationMVArun2v1DBnewDMwLT2017v2' 'byVVTightIsolationMVArun2v1DBnewDMwLT2017v2' 'byIsolationMVArun2v1DBdR03oldDMwLTraw2017v2' 'byLooseIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byMediumIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byTightIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byVLooseIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byVTightIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byVVLooseIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byVVTightIsolationMVArun2v1DBdR03oldDMwLT2017v2' 'byIsolationMVArun2v1DBoldDMwLTraw2017v2' 'byLooseIsolationMVArun2v1DBoldDMwLT2017v2' 'byMediumIsolationMVArun2v1DBoldDMwLT2017v2' 'byTightIsolationMVArun2v1DBoldDMwLT2017v2' 'byVLooseIsolationMVArun2v1DBoldDMwLT2017v2' 'byVTightIsolationMVArun2v1DBoldDMwLT2017v2' 'byVVLooseIsolationMVArun2v1DBoldDMwLT2017v2' 'byVVTightIsolationMVArun2v1DBoldDMwLT2017v2' 'byIsolationMVArun2v1DBoldDMwLTraw2015' 'byLooseIsolationMVArun2v1DBoldDMwLT2015' 'byMediumIsolationMVArun2v1DBoldDMwLT2015' 'byTightIsolationMVArun2v1DBoldDMwLT2015' 'byVLooseIsolationMVArun2v1DBoldDMwLT2015' 'byVTightIsolationMVArun2v1DBoldDMwLT2015' 'byVVTightIsolationMVArun2v1DBoldDMwLT2015' .
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 04-Jul-2021 22:45:19 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 1
   [1] Running path 'NANOEDMAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'NANOEDMAODSIMoutput'
   [3] Prefetching for module CandMCMatchTableProducer/'boostedTauMCTable'
   [4] Calling method for module PATTauRefSelector/'finalBoostedTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Tau>
Looking for module label: slimmedTausBoostedNewID
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 04-Jul-2021 22:53:35 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'NANOEDMAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'NANOEDMAODSIMoutput'
   [3] Prefetching for module CandMCMatchTableProducer/'boostedTauMCTable'
   [4] Calling method for module PATTauRefSelector/'finalBoostedTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Tau>
Looking for module label: slimmedTausBoostedNewID
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
  • 136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
  • 136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

Pull request #34329 was updated. @gouskos, @silviodonato, @fabiocos, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be3056/17197/summary.html
COMMIT: c0ac0dd
CMSSW: CMSSW_12_0_X_2021-07-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34329/17197/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
  • 1329.11329.1_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X/step2_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 442 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -34.753 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 1325.81 ): -20.947 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 136.8523 ): -13.810 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 1 / 37 workflows

@mariadalfonso
Copy link
Contributor Author

status so far :)

  1. the 8X fail on the genSubJetAK8Table (module that should be deactivated)
  2. differences are seen in the ele.photon.met as expected (since I deactivated them),
    but the jetTable should not show any difference in the run2_nanoAOD_106Xv1 and run2_nanoAOD_106Xv2 , and it does
    https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-07-25-2300+be3056/44349/validateJR.html

once I fix this jet, I move all the non ele/ph/met in a separate PR that can be merged right away w.o breaking anything

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34329/24223

@cmsbuild
Copy link
Contributor

Pull request #34329 was updated. @gouskos, @silviodonato, @fabiocos, @cmsbuild, @fgolf, @qliphy, @mariadalfonso, @davidlange6 can you please check and sign again.

@mariadalfonso
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be3056/17221/summary.html
COMMIT: b2d6538
CMSSW: CMSSW_12_0_X_2021-07-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34329/17221/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
  • 1329.11329.1_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X/step2_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 442 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -34.753 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 1325.81 ): -20.947 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 136.8523 ): -13.810 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 1 / 37 workflows

@mariadalfonso
Copy link
Contributor Author

I close this, given that has been splitted in 3 smaller PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants