Correct RegionalMuon (un)packer when running on EMTF data #34801
Conversation
…placement info EMTF doesn't yet send displaced muon information, but unfortunately sends debug data in the fields foreseen for use by dXY and pT unconstrained. With this change we avoid unpacking those data until the uGMT firmare version changes to indicate that we actually use it in the algorithm.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34801/24525
|
|
A new Pull Request was created by @dinyar (Dinyar Rabady) for master. It involves the following packages:
@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-437135/17628/summary.html Comparison SummarySummary:
|
|
Had a look at the DQM bin by bin comparisons and those don't show any relevant differences (as expected). |
|
@cms-sw/l1-l2 any comment? |
|
hi all, @dinyar thx for the ping |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
please test |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-437135/18196/summary.html Comparison SummarySummary:
|
|
+1 |
PR description:
EMTF doesn't yet send displaced muon information, but unfortunately puts debug data in the fields foreseen for use by dXY and unconstrained pT. This leads to mismatches in the uGMT data-emulator DQM because we unpack these debug data, interpret them as dXY and unconstrained pT, and then proceed to run the emulator on these inputs. The emulator output therefore doesn't match the firmware output anymore as the firmware correctly ignores those data.
With this change we avoid unpacking those fields until the uGMT firmware version changes to indicate that we actually use them in the algorithm.
attn: @panoskatsoulis as the BMTF output (un)packer slightly changes too.
PR validation:
Ran
scram b runtests && runTheMatrix.py -l limited -i all --ibeossuccessfully.