Create abstract XrdStatistics class

[Dr15Jones]

PR description:

CondorStatusUpdater now only depends on the abstract XrdStatistics interface. The edm::Service is now accessed only via the base class, not the concrete class.

This avoids including a header from the /src directory.

PR validation:

Code compiles and all framework unit tests succeed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34802/24526

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/XrdAdaptor/plugins/XrdStorageMaker.cc modified in PR(s): XrdAdaptor: Fix race condition leading to a crash when doing Prepare … #32763, [XrdAdaptor] Modifications for xrootd-5.3 #34700

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Services (core)
• Utilities/XrdAdaptor (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34802/24528

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/XrdAdaptor/plugins/XrdStorageMaker.cc modified in PR(s): XrdAdaptor: Fix race condition leading to a crash when doing Prepare … #32763, [XrdAdaptor] Modifications for xrootd-5.3 #34700

[cmsbuild]

Pull request #34802 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e78c94/17589/summary.html
COMMIT: 5b76a72
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34802/17589/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [MagneticField] Move public headers to interface directory #34763
• @srimanob Allow multiple "--command" in runTheMatrix #34722
• @bsunanda Run3-TB63 Rearrange the files in SimG4CMS/HcalTestBeam #34770
• @ptcox fix incomplete esconsumes migration #34631

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e78c94/17589/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e78c94/17589/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1