-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSC TP efficiency producer in standard Validation sequence #35135
Add CSC TP efficiency producer in standard Validation sequence #35135
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35135/25042
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages:
@civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd4869/18267/summary.html Comparison SummarySummary:
|
+1 |
@civanch Do you have any comments? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
We noticed that the efficiencies for the CSC TP efficiencies were not being added in the Validation step. There is an occupancy directory with denominators and numerators. There should be an efficiency directory with plots as well, but clearly it's not there. This PR fixes that.
Denominators and numerators
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: