Added esConsumes to VirtualJetProducer classes

[Dr15Jones]

PR description:

• changed reco::writeSpecific jet helper functions to no longer take an EventSetup
• have VirtualJetProducer base class do esConsumes and added protected function to get the ES data products.

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35276/25273

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• RecoJets/JetProducers (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbaa8e/18616/summary.html
COMMIT: 3c011eb
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35276/18616/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetTreeDump.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetVertexAdder.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetProducer.cc: In instantiation of 'void FFTJetProducer::writeJets(edm::Event&, const edm::EventSetup&) [with Jet = reco::CaloJet]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetProducer.cc:604:3:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetProducer.cc:568:18: error: no matching function for call to 'writeSpecific(reco::CaloJet&, fftjetcms::VectorLike&, const Point&, __gnu_cxx::__alloc_traits > >, std::vector > >::value_type&, const edm::EventSetup&)'
  568 |     writeSpecific(jet, jet4vec, vertexUsed(), constituents[ijet + 1], iSetup);
      |     ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/FFTJetProducers/plugins/FFTJetProducer.cc:40:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-14-1100/src/RecoJets/JetProducers/interface/JetSpecific.h:28:8: note: candidate: 'void reco::writeSpecific(reco::CaloJet&, const LorentzVector&, const Point&, const std::vector >&, const CaloGeometry&, const HcalTopology&)'
   28 |   void writeSpecific(reco::CaloJet& jet,


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35276/25292

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request #35276 was updated. @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35276/25423

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #35276 was updated. @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbaa8e/18794/summary.html
COMMIT: cd53143
CMSSW: CMSSW_12_1_X_2021-09-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35276/18794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• as in Added esConsumes to VirtualJetProducer classes #35276 (comment)

[qliphy]

+1

[qliphy]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.