-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS renaming AlCa Prompt producers and PPSCalTrackBasedSel AlCa Reco to autoAlca.py #36702
PPS renaming AlCa Prompt producers and PPSCalTrackBasedSel AlCa Reco to autoAlca.py #36702
Conversation
PromptCalibProdPPS -> PromptCalibProdPPSTimingCalib
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36702/27778
|
A new Pull Request was created by @grzanka (Leszek Grzanka) for master. It involves the following packages:
@perrotta, @malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
@cmsbuild please abort |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a7ada/21718/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@cmsbuild , please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1
|
Hi @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 please consider signing it again, there was nothing changed from what you already signed earlier |
+Upgrade Technical PR on renaming of PPS Timing Calibration alca prompt producer. PR test runs fine. |
+1 |
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
merge |
PR description:
This PR is a refactoring (renaming) of the AlCa Prompt producers responsible for PPS Timing Calibration.
It resolves cms-AlCaDB/AlCaTools#53
The changes are necessary for T0 replay with PPS. The suggestions for renaming appeared in the discussion of #36273
It is following #36698
This PR initially contained refactoring of PPS timing calibration producers (hence the branch name
CTPPS:pps_timing_calibration_tier0_renaming
).As suggested in #36702 (comment)
I've merged here as well commits from other PRs:
PR validation:
Tested with: