[12.3.X] fix the cms EDModule type of GenParticleMatchMerger

[mmusich]

backport of #37613

PR description:

It appears that CollectionAdder

cmssw/CommonTools/UtilAlgos/interface/CollectionAdder.h

Line 17 in 837fd56

class CollectionAdder : public edm::global::EDProducer<> {

which is the underlying module type of

cmssw/PhysicsTools/HepMCCandAlgos/plugins/GenParticleMatchMerger.cc

Line 4 in 6d2f660

typedef CollectionAdder<reco::GenParticleMatch> GenParticleMatchMerger;

is an EDProducer, but it was declared in the configuration as an EDFilter:

cmssw/SimTracker/TrackAssociation/python/allTrackMCMatch_cfi.py

Line 3 in 837fd56

allTrackMCMatch = cms.EDFilter("GenParticleMatchMerger",

leading to runtime errors of the type:

----- Begin Fatal Exception 19-Apr-2022 00:54:18 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=GenParticleMatchMerger label='allTrackMCMatch'
Exception Message:
The base type in the python configuration is EDFilter, but the base type
for the module's C++ class is EDProducer. Please fix the configuration.
It must use the same base type as the C++ class.
----- End Fatal Exception -------------------------------------------------

this is trivially fixed here.
In addition in commit f68a4df, I take care of some other mismatched types in the configuration.
The parameter associator of MCTrackMatcher should be a cms.string and not a cms.InputTag:

cmssw/SimTracker/TrackAssociation/plugins/MCTrackMatcher.cc

Line 44 in 9583b99

: associator_(consumes<reco::TrackToTrackingParticleAssociator>(p.getParameter<string>("associator"))),

Finally in the same commit, the value of the variable associator in Tracker/TrackAssociation/python/trackMCMatch_cfi.py is corrected such that it is trackAssociatorByHits and not TrackAssociatorByHits

PR validation:

Private scripts.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #37613.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

• SimTracker/TrackAssociation (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mtosi, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @jhgoh, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from fix the cms EDModule type of GenParticleMatchMerger #37613

[mmusich]

type bug-fix

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a83e/24123/summary.html
COMMIT: f3677ff
CMSSW: CMSSW_12_3_X_2022-04-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37652/24123/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697135
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697105
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of fix the cms EDModule type of GenParticleMatchMerger #37613
• Merge and let it there, just in case a new release for this cycle gets requested