[12_3_X] update BeamSpot HLT client to use correct raw data from TCDS

[francescobrivio]

PR description:

During the first runs with Stable Beams at 900 GeV in 2022 (Fill 7652) we realized that the BeamSpot HLT DQM client was correctly working (producing the beamspot DQM plots and the expected txt files), but no payload (or log) was uploaded to CondDB.

After some debugging this has been traced down to the fact that the stream DQMOnlineBeamspot does not contain information on raw tcds data. The need for raw tcds data was introduced in #37614 and it is used to assess the presence of Stable Beams or not.

This PR adds the correct rawDataInputTag for the beamhlt DQM client and should be deployed in online DQM together with the new menu changes discussed in JIRA CMSHLT-2325 (more details are also available in the JIRA).

PR validation:

Code compiles.
We can't do much more testing at the moment because we need a streamer file with the updated menu.

Backport:

Not a backport but forwardports to 12_4_X and 12_5_X will be opened soon.
Improvements to the unitTest will be added in a subsequent PR.

FYI @mmusich @dzuolo @gennai @missirol @Sam-Harper @boudoul

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)
• DQM/Integration (dqm)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from update BeamSpot HLT client to use correct raw data from TCDS #38110

[francescobrivio]

@cmsbuild please test

[pmandrik]

Successfully tested at DQM P5 playback using 352425 run, @emanueleusai

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b69f9/25044/summary.html
COMMIT: 480341e
CMSSW: CMSSW_12_3_X_2022-05-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38103/25044/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3627395
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3627365
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• change according to the PR description
• test pass, tested at P5

[francescobrivio]

Just for reference, after this was deployed in production with the new menu, I can confirm that the beamhlt client is now working as expected from run 352493 and new payloads are being uploaded to CondDB:

And the onlinebeammonitor client, which reads the payloads from the DB and makes the final decision, is correctly showing that both options (from beam and beamhlt clients) are available:

[francescobrivio]

backport of #38110

[tvami]

type bugfix

[francescobrivio]

@cms-sw/dqm-l2 a kind ping for signing this PR, it is already deployed online in P5 (see #38103 (comment)).

[pmandrik]

+1

[cmsbuild]

Pull request #38103 was updated. @malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b69f9/25155/summary.html
COMMIT: 4911996
CMSSW: CMSSW_12_3_X_2022-06-01-1200/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38103/25155/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3627388
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3627346
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+db

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[francescobrivio]

Just for the record, the new label hltFEDSelectorTCDS added in the last commit (4911996) is working properly.
See e.g. run 352900: