Add EGamma calo ID variable cut to Run 3 Scouting Electrons #38597
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38597/30858
|
|
A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| << "absEtaLowEdges and egammaSigmaIEtaIEtaCut vectors should be of the same size. \n"; | ||
| } | ||
|
|
||
| for (unsigned int aIt = 0; aIt < absEtaLowEdges.size() - 1; aIt++) { |
There was a problem hiding this comment.
This looks unguarded against the case size() == 0. What should the producer do in that case?
There was a problem hiding this comment.
If the size()==0, then the loop condition evaluates to false by default. We do not need a check for the values if the vector is empty, to begin with. If there is a default way to do this, please suggest @missirol. The "-1" in the loop condition is necessary to prevent a seg fault when checking the last entry of the vector.
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38597/30869
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
apply code formatting add 1D differnce and change rechit indput tag fix a bug
Co-authored-by: Marino Missiroli <[email protected]>
arsahasransu
force-pushed
the
checkEgammaCutforScouting
branch
from
b2f6698 to
7aef092
Compare
|
I made an error while squashing so I will make a fresh commit. Sorry for the bug. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38597/30874
|
|
Pull request #38597 was updated. @perrotta, @Martin-Grunewald, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @clacaputo, @jpata, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please check and sign again. |
PR description:
Add the sigmaietaieta calo id variable cut to the Run 3 scouting electron collection