Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HiggsMonitoring_cff.py #39426

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Update HiggsMonitoring_cff.py #39426

merged 1 commit into from
Sep 21, 2022

Conversation

kauraman02
Copy link
Contributor

PR description:
This PR contains updates for Run3, small fixes to the trigger DQM codes for the Dileptonic and TriLeptonic paths within Higgs Monitoring module.

Slide 38,39

PR validation:

Successful tests:

  • CMSSW_12_4_0: Test performed with 100 events from the TTbar sample, in which folders/histograms were correctly produced and filled with events:

    followed the instruction from twiki : HLTValidationAndDQM

  • Basic tests:

    scram b distclean
    git cms-checkdeps -a -A
    scram b -j 8
    scram b runtests
    scram build code-checks
    scram build code-format
    runTheMatrix.py -l 11634.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39426/32136

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kauraman02 (Amandeep Kaur) for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

type bug

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-558679/27620/summary.html
COMMIT: eb1ff36
CMSSW: CMSSW_12_6_X_2022-09-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39426/27620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618332
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618308
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3170.85 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 528.475 KiB HLT/HIG
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e8c13cd into cms-sw:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants