Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME11aUnganged #3949

Closed
wants to merge 1 commit into from
Closed

ME11aUnganged #3949

wants to merge 1 commit into from

Conversation

degrutto
Copy link
Contributor

update code to handle properly the ME11aunganging

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @degrutto (michele de gruttola) for CMSSW_7_1_X.

ME11aUnganged

It involves the following packages:

L1Trigger/CSCTrackFinder

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

Queue new features for 72x rather than 71x (and we'll need a different solution for all the bin and data files in this PR). @mulhearn, please followup)

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFDTReceiver.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFDTReceiverLUT.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFMuonSorter.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFPtLUT.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFDTReceiver.cc: In member function 'CSCTriggerContainercsctf::TrackStub CSCTFDTReceiver::process(const L1MuDTChambPhContainer_)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFDTReceiver.cc:40:16: error: invalid conversion from 'const L1MuDTChambPhDigi_' to 'L1MuDTChambPhDigi_' [-fpermissive]
     dtts[stub] = (stub == 0) ? dttrig->chPhiSegm1(wheel,1,iss,bx) :
                ^
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFPtMethods.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-05-21-0200/src/L1Trigger/CSCTrackFinder/src/CSCTFSPCoreLogic.cc 
gmake: *_\* [tmp/slc6_amd64_gcc481/src/L1Trigger/CSCTrackFinder/src/L1TriggerCSCTrackFinder/CSCTFDTReceiver.o] Error 1


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3949/5/summary.html

@degrutto
Copy link
Contributor Author

ok sorry,
I believe I was checking the code on 62X.... but submitted (by mistake) to 71X without realizing some other changes where made (I did not touch at all the class src/L1TriggerCSCTrackFinder/CSCTFDTReceiver.cc in my area)
Please do expect from me soon a new pull request,
and meanwhile ignore this? how does it work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants