Catch case where parent index is bad in Hydjet #39874

Dr15Jones · 2022-10-27T14:05:47Z

PR description:

Parent index should not be larger than child index for hydjet. This occurred when there was a high multiplicity which is causing an index overflow in the Fortran code.
Now throw an exception when parent index is larger than child index. This is much preferred over the segmentation fault happening now.

PR validation:

Ran a job which before change would have a segmentation fault but after change throws exception and ends cleanly.

This reverts commit 9162d5f.

Dr15Jones · 2022-10-27T14:05:56Z

FYI @wouf

Dr15Jones · 2022-10-27T14:08:38Z

Based on discussion in #39784

Dr15Jones · 2022-10-27T14:09:11Z

please test workflow 159.03

cmsbuild · 2022-10-27T14:13:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39874/32787

This PR adds an extra 16KB to repository

cmsbuild · 2022-10-27T14:13:24Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/HydjetInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

wouf · 2022-10-27T14:58:23Z

This PR related to cms-sw/cmsdist#8154

wouf · 2022-10-27T17:40:05Z

@Dr15Jones, could You please to update this PR to kMaxMultiplicity = 200000

cmsbuild · 2022-10-27T17:42:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84438c/28564/summary.html
COMMIT: 15726d8
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39874/28564/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-84438c/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
Reco comparison had 6 failed jobs
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3384029
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3383998
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

Dr15Jones · 2022-10-27T18:22:13Z

please test with cmsdist#8154

cmsbuild · 2022-10-27T18:29:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39874/32801

This PR adds an extra 16KB to repository

cmsbuild · 2022-10-28T02:32:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84438c/28583/summary.html
COMMIT: 1fb8c91
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39874/28583/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84438c/28583/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84438c/28583/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1076 differences found in the comparisons
Reco comparison had 6 failed jobs
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3384029
DQMHistoTests: Total failures: 2958
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3381049
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 201 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2022-10-31T08:19:33Z

test parameters:

pull_request = Update hydjet.spec cmsdist#8154
workflow = 159.03
enable = threading
workflow_threading = 159.03

smuzaffar · 2022-10-31T08:24:20Z

please test

cmsbuild · 2022-10-31T12:49:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84438c/28657/summary.html
COMMIT: 1fb8c91
CMSSW: CMSSW_12_6_X_2022-10-30-2300/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39874/28657/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-84438c/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416356
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3416331
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 211 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2022-11-02T22:44:28Z

@cms-sw/generators-l2 , if this PR looks good then should we go ahead with hydjet 1.9.3 ( cms-sw/cmsdist#8154 ) integration?

SiewYan · 2022-11-07T01:46:36Z

It is fine by me, @Saptaparna , @menglu21 , could you confirm and sign it? thanks

Saptaparna · 2022-11-08T02:15:44Z

+1

cmsbuild · 2022-11-08T02:16:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-11-08T02:55:06Z

+1

wouf · 2022-11-08T10:06:05Z

It won't work properly without cms-sw/cmsdist#8154 !

Dr15Jones added 2 commits October 27, 2022 08:16

Revert "Deal with late mothers in HydjetHadronizer"

d577b49

This reverts commit 9162d5f.

Throw exception when problem with parent index in hydjet

15726d8

cmsbuild added this to the CMSSW_12_6_X milestone Oct 27, 2022

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Oct 27, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 27, 2022

smuzaffar mentioned this pull request Oct 27, 2022

Update hydjet.spec cms-sw/cmsdist#8154

Merged

cmsbuild added tests-approved and removed tests-started labels Oct 27, 2022

Changed kMaxMultiplicity to 200000 to match change to hydjet

1fb8c91

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Oct 27, 2022

cmsbuild added requires-external tests-started labels Oct 27, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 28, 2022

cmsbuild added tests-started and removed tests-approved labels Oct 31, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 31, 2022

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Nov 8, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 8, 2022

cmsbuild merged commit b43b194 into cms-sw:master Nov 8, 2022

This was referenced Nov 8, 2022

use EvFFEDExcluder instead of EvFFEDSelector for rawPrimeDataRepacker #40005

Merged

Setting precision in GlobalVariablesProducer #39955

Merged

Photon MVA-based ID for Run3 from EGamma POG #39927

Merged

Dr15Jones mentioned this pull request Nov 14, 2022

range_check error in HydjetGeneratorFilter #39865

Closed

Dr15Jones deleted the hydjetOverflow branch November 16, 2022 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Catch case where parent index is bad in Hydjet #39874

Catch case where parent index is bad in Hydjet #39874

Dr15Jones commented Oct 27, 2022

Dr15Jones commented Oct 27, 2022

Dr15Jones commented Oct 27, 2022

Dr15Jones commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

wouf commented Oct 27, 2022 •

edited

Loading

wouf commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

Dr15Jones commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

cmsbuild commented Oct 28, 2022

smuzaffar commented Oct 31, 2022 •

edited

Loading

smuzaffar commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

smuzaffar commented Nov 2, 2022

SiewYan commented Nov 7, 2022

Saptaparna commented Nov 8, 2022

cmsbuild commented Nov 8, 2022

perrotta commented Nov 8, 2022 •

edited

Loading

wouf commented Nov 8, 2022

Catch case where parent index is bad in Hydjet #39874

Catch case where parent index is bad in Hydjet #39874

Conversation

Dr15Jones commented Oct 27, 2022

PR description:

PR validation:

Dr15Jones commented Oct 27, 2022

Dr15Jones commented Oct 27, 2022

Dr15Jones commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

wouf commented Oct 27, 2022 • edited Loading

wouf commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

Comparison Summary

Dr15Jones commented Oct 27, 2022

cmsbuild commented Oct 27, 2022

cmsbuild commented Oct 28, 2022

Comparison Summary

smuzaffar commented Oct 31, 2022 • edited Loading

smuzaffar commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

Comparison Summary

smuzaffar commented Nov 2, 2022

SiewYan commented Nov 7, 2022

Saptaparna commented Nov 8, 2022

cmsbuild commented Nov 8, 2022

perrotta commented Nov 8, 2022 • edited Loading

wouf commented Nov 8, 2022

wouf commented Oct 27, 2022 •

edited

Loading

smuzaffar commented Oct 31, 2022 •

edited

Loading

perrotta commented Nov 8, 2022 •

edited

Loading