Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41522

Merged
merged 2 commits into from
May 4, 2023
Merged

[CORE] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41522

merged 2 commits into from
May 4, 2023

Conversation

smuzaffar
Copy link
Contributor

  • Fixed set but unused warnings from clang-16 in CLANG IBs.
  • Added couple of cout sothat compiler do not complain about set but unused variables.

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone May 4, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41522/35394

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • DataFormats/Common (core)
  • DataFormats/Provenance (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

makortel
makortel reviewed May 4, 2023
View reviewed changes
DataFormats/Common/test/testOneToManyAssociation.cc
@@ -67,6 +68,7 @@ void testOneToManyAssociation::dummy() {
++f;
n = v.numberOfAssociations(edm::Ref<CKey>());
++n;
std::cout << "numberOfAssociations:" << n << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this test code does not use particularly useful. Ok, it ensures the syntax compiles and the whatever the compiler leaves there after optimizations runs, but it could use more assertions. Something to be possibly improved later though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makortel , I am not sure if unit test is testing this code, I do not see this printout in the log file https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07754a/32373/unitTests/src/DataFormats/Common/test/testDataFormatsCommon/testing.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, this code is there to check if it compiles

@makortel
Copy link
Contributor

makortel commented May 4, 2023

@cmsbuild, please test

@makortel makortel mentioned this pull request May 4, 2023
Open
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07754a/32373/summary.html
COMMIT: 890af69
CMSSW: CMSSW_13_1_X_2023-05-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41522/32373/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 3854 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 4822
  • DQMHistoTests: Total nulls: 55
  • DQMHistoTests: Total successes: 3455978
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@makortel makortel mentioned this pull request May 4, 2023
Open
@makortel
Copy link
Contributor

makortel commented May 4, 2023

Another occurrence of #35109

@makortel
Copy link
Contributor

makortel commented May 4, 2023

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 4, 2023

+1

@cmsbuild cmsbuild merged commit bcaef7f into cms-sw:master May 4, 2023
@cmsbuild cmsbuild mentioned this pull request May 5, 2023
Merged
@aandvalenzuela aandvalenzuela mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@smuzaffar @cmsbuild @makortel @perrotta