[HLT] [CLANG] Fix warnings reported by llvm16 in CLANG IBs

[smuzaffar]

Fixed set but unused warnings from clang-16 in CLANG IBs

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41533/35405

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• HLTrigger/Egamma (hlt)
• HLTrigger/JetMET (hlt)
• HLTrigger/Muon (hlt)
• HLTrigger/btau (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @missirol, @silviodonato, @AnnikaStein, @andrea21z, @abbiendi, @jhgoh, @Martin-Grunewald, @JyothsnaKomaragiri, @HuguesBrun, @Fedespring, @CeliaFernandez, @andrzejnovak, @demuller, @trocino, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[missirol]

@smuzaffar , I don't know if you think it's useful to test this for "CLANG_X" or other non-standard builds.

If so, feel free to start those tests. (I didn't do it because the fixes seem straightforward)

[smuzaffar]

@smuzaffar , I don't know if you think it's useful to test this for "CLANG_X" or other non-standard builds.

If so, feel free to start those tests. (I didn't do it because the fixes seem straightforward)

No, there is no need to test these PR against CLANG_X IBs. If chanegs look reasonable then test for default/master IBs should be enough

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-269e70/32376/summary.html
COMMIT: 3ee5da0
CMSSW: CMSSW_13_1_X_2023-05-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41533/32376/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 3861 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 4832
• DQMHistoTests: Total nulls: 55
• DQMHistoTests: Total successes: 3455968
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

please test

47459 unexpected (?) DQM differences in wf 23634.911. I don't think this PR can explain it (so I'm not holding it), but I'd be curious to see what happens rerunning the tests.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-269e70/32387/summary.html
COMMIT: 3ee5da0
CMSSW: CMSSW_13_1_X_2023-05-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41533/32387/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 3865 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 4831
• DQMHistoTests: Total nulls: 55
• DQMHistoTests: Total successes: 3455969
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[perrotta]

+1

[missirol]

47459 unexpected (?) DQM differences in wf 23634.911. I don't think this PR can explain it (so I'm not holding it), but I'd be curious to see what happens rerunning the tests.

Same discrepancies after running the tests a 2nd time. I can only guess that the non-reproducibility hit the baseline (?).