Updated nano matrix 13.2 #41867

vlimant · 2023-06-05T09:30:28Z

PR description:

this updates the NANO matrix with relevant workflows. A partial back port to 13.0.X is expected

PR validation:

runTheMatrix.py --what nano --nEvents 10 ran successfully

cmsbuild · 2023-06-05T09:35:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41867/35775

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): Custom Run 3 PFScouting NanoAOD #40438

cmsbuild · 2023-06-05T09:35:31Z

A new Pull Request was created by @vlimant (vlimant) for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

vlimant · 2023-06-05T09:43:20Z

enable nano

vlimant · 2023-06-05T09:43:50Z

please test

cmsbuild · 2023-06-05T11:37:13Z

-1

Failed Tests: RelVals RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18952a/32976/summary.html
COMMIT: 80146c6
CMSSW: CMSSW_13_2_X_2023-06-04-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41867/32976/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

ValueError: Undefined workflows: 2500.601

RelVals-INPUT

2500.2DAS Error
2500.31DAS Error
2500.311DAS Error

RelVals-NANO

2500.2DAS Error
2500.31DAS Error
2500.311DAS Error

vlimant · 2023-06-07T09:23:07Z

@smuzaffar : there are new input files here. Is there anything to be done to get them staged to IB IOS space?

vlimant · 2023-06-07T09:23:16Z

please test

cmsbuild · 2023-06-07T10:20:15Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18952a/33027/summary.html
COMMIT: 80146c6
CMSSW: CMSSW_13_2_X_2023-06-06-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41867/33027/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 2500.601

NANO Comparison Summary

The workflows 2500.311, 2500.31 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 0
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 0
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 0 log files, 0 edm output root files, 3 DQM output files

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.0-size.json
Nano ERROR: Missing ref/2500.0-size.json
Nano ERROR: Missing ref/2500.001-size.json
Nano ERROR: Missing ref/2500.001-size.json
Nano ERROR: Missing ref/2500.002-size.json
Nano ERROR: Missing ref/2500.002-size.json
Nano ERROR: Missing ref/2500.01-size.json
Nano ERROR: Missing ref/2500.01-size.json
Nano ERROR: Missing ref/2500.011-size.json
Nano ERROR: Missing ref/2500.011-size.json
Nano ERROR: Missing ref/2500.012-size.json
Nano ERROR: Missing ref/2500.012-size.json
Nano ERROR: Missing ref/2500.1-size.json
Nano ERROR: Missing ref/2500.1-size.json
Nano ERROR: Missing ref/2500.2-size.json
Nano ERROR: Missing ref/2500.2-size.json
Nano ERROR: Missing ref/2500.21-size.json
Nano ERROR: Missing ref/2500.21-size.json
Nano ERROR: Missing ref/2500.211-size.json
Nano ERROR: Missing ref/2500.211-size.json
Nano ERROR: Missing ref/2500.3-size.json
Nano ERROR: Missing ref/2500.3-size.json
Nano ERROR: Missing ref/2500.4-size.json
Nano ERROR: Missing ref/2500.4-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.31 | 1.207 | 2.438 | -1.231 ( -50.5% ) | 20.97 | 5.43 | +286.4% | 2.088 | 2.116 |
| 2500.311 | 1.584 | 2.545 | -0.962 ( -37.8% ) | 15.66 | 4.84 | +223.3% | 2.158 | 2.544 |

srimanob · 2023-06-12T18:19:21Z

Hi @vlimant
Should you also update https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L85

I don't see 12.6 wf anymore, maybe you need to pick another version instead,

2500.0 TTbarMINIAOD10.6_UL16v2+NANO_mc10.6ul16v2+HRV_NANO_mc 
2500.001 TTbarMINIAOD10.6_UL17v2+NANO_mc10.6ul17v2+HRV_NANO_mc 
2500.002 TTbarMINIAOD10.6_UL18v2+NANO_mc10.6ul18v2+HRV_NANO_mc 
2500.01 MuonEG2016MINIAOD10.6v2+NANO_data10.6ul16v2+HRV_NANO_data 
2500.011 MuonEG2017MINIAOD10.6v2+NANO_data10.6ul17v2+HRV_NANO_data 
2500.012 MuonEG2018MINIAOD10.6v2+NANO_data10.6ul18v2+HRV_NANO_data 
2500.1 TTbarMINIAOD12.2+NANO_mc12.2+HRV_NANO_mc 
2500.2 TTbarMINIAOD12.4+NANO_mc12.4+HRV_NANO_mc 
2500.21 MuonEG2022MINIAOD12.4+NANO_data12.4+HRV_NANO_data 
2500.211 MuonEG2022MINIAOD12.4+NANO_data12.4_prompt+HRV_NANO_data 
2500.3 TTBarMINIAOD13.0+NANO_mc13.0+HRV_NANO_mc 
2500.31 MuonEG2023MINIAOD13.0+NANO_data13.0+HRV_NANO_data 
2500.311 MuonEG2023MINIAOD13.0+NANO_data13.0_prompt+HRV_NANO_data 
2500.4 TTBarMINIAOD13.2+NANO_mc13.2+HRV_NANO_mc

vlimant · 2023-06-13T08:04:08Z

good point @srimanob

vlimant · 2023-06-13T08:04:59Z

please test

cmsbuild · 2023-06-13T08:12:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41867/35898

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): Custom Run 3 PFScouting NanoAOD #40438
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255

cmsbuild · 2023-06-13T08:13:17Z

Pull request #41867 was updated. @bbilin, @srimanob, @sunilUIET, @kskovpen, @AdrianoDee can you please check and sign again.

cmsbuild · 2023-06-13T10:37:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18952a/33114/summary.html
COMMIT: c15e6ea
CMSSW: CMSSW_13_2_X_2023-06-12-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41867/33114/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 51 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3189640
DQMHistoTests: Total failures: 2228
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3187390
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 205 log files, 158 edm output root files, 47 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

The workflows 2500.311, 2500.31 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 0
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 0
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 0 log files, 0 edm output root files, 3 DQM output files

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.0-size.json
Nano ERROR: Missing ref/2500.0-size.json
Nano ERROR: Missing ref/2500.001-size.json
Nano ERROR: Missing ref/2500.001-size.json
Nano ERROR: Missing ref/2500.002-size.json
Nano ERROR: Missing ref/2500.002-size.json
Nano ERROR: Missing ref/2500.01-size.json
Nano ERROR: Missing ref/2500.01-size.json
Nano ERROR: Missing ref/2500.011-size.json
Nano ERROR: Missing ref/2500.011-size.json
Nano ERROR: Missing ref/2500.012-size.json
Nano ERROR: Missing ref/2500.012-size.json
Nano ERROR: Missing ref/2500.1-size.json
Nano ERROR: Missing ref/2500.1-size.json
Nano ERROR: Missing ref/2500.2-size.json
Nano ERROR: Missing ref/2500.2-size.json
Nano ERROR: Missing ref/2500.21-size.json
Nano ERROR: Missing ref/2500.21-size.json
Nano ERROR: Missing ref/2500.211-size.json
Nano ERROR: Missing ref/2500.211-size.json
Nano ERROR: Missing ref/2500.3-size.json
Nano ERROR: Missing ref/2500.3-size.json
Nano ERROR: Missing ref/2500.4-size.json
Nano ERROR: Missing ref/2500.4-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.31 | 1.207 | 2.438 | -1.231 ( -50.5% ) | 20.52 | 5.47 | +275.2% | 2.059 | 2.136 |
| 2500.311 | 1.584 | 2.546 | -0.962 ( -37.8% ) | 15.66 | 4.88 | +221.3% | 2.111 | 2.563 |

srimanob · 2023-06-13T10:51:08Z

+Upgrade

srimanob · 2023-06-13T16:41:16Z

I assume this PR is ready to go, right @vlimant ?
Kindly ping @cms-sw/pdmv-l2 to review. Thanks.

kskovpen · 2023-06-14T05:59:56Z

+pdmv

cmsbuild · 2023-06-14T06:00:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-06-14T16:09:55Z

+1

vlimant added 2 commits June 5, 2023 10:56

removed 12.6 input workflows. added 13.0 and 13.2 ones

08d519b

dynamic numbering scheme back

80146c6

cmsbuild added this to the CMSSW_13_2_X milestone Jun 5, 2023

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Jun 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 5, 2023

cmsbuild added tests-started and removed tests-pending labels Jun 5, 2023

cmsbuild added tests-rejected and removed tests-started labels Jun 5, 2023

cmsbuild added tests-started and removed tests-rejected labels Jun 7, 2023

cmsbuild added tests-rejected and removed tests-started labels Jun 7, 2023

change nano workflow in default matrix

c15e6ea

cmsbuild added the code-checks-pending label Jun 13, 2023

cmsbuild added tests-started and removed tests-pending labels Jun 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 13, 2023

cmsbuild added tests-approved and removed tests-started labels Jun 13, 2023

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 13, 2023

cmsbuild mentioned this pull request Jun 13, 2023

Guard for No Digis for Phase2 and Patatrack NuGun #41255

Merged

srimanob mentioned this pull request Jun 13, 2023

Custom Run 3 PFScouting NanoAOD #40438

Merged

cmsbuild mentioned this pull request Jun 13, 2023

Migrate Phase-2 geometry to D98 #41946

Merged

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Jun 14, 2023

cmsbuild added orp-approved and removed orp-pending labels Jun 14, 2023

cmsbuild merged commit 36b5476 into cms-sw:master Jun 14, 2023

cmsbuild mentioned this pull request Jun 14, 2023

GCC 11.4; CUDA 11.8; cleanup for cmsplatf/cmsos use cms-sw/cmsdist#8545

Merged

vlimant deleted the updated_nano_matrix_13.2 branch March 4, 2024 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated nano matrix 13.2 #41867

Updated nano matrix 13.2 #41867

vlimant commented Jun 5, 2023

cmsbuild commented Jun 5, 2023

cmsbuild commented Jun 5, 2023

vlimant commented Jun 5, 2023

vlimant commented Jun 5, 2023

cmsbuild commented Jun 5, 2023

vlimant commented Jun 7, 2023

vlimant commented Jun 7, 2023

cmsbuild commented Jun 7, 2023

srimanob commented Jun 12, 2023

vlimant commented Jun 13, 2023

vlimant commented Jun 13, 2023

cmsbuild commented Jun 13, 2023

cmsbuild commented Jun 13, 2023

cmsbuild commented Jun 13, 2023

srimanob commented Jun 13, 2023

srimanob commented Jun 13, 2023

kskovpen commented Jun 14, 2023

cmsbuild commented Jun 14, 2023

rappoccio commented Jun 14, 2023

Updated nano matrix 13.2 #41867

Updated nano matrix 13.2 #41867

Conversation

vlimant commented Jun 5, 2023

PR description:

PR validation:

cmsbuild commented Jun 5, 2023

cmsbuild commented Jun 5, 2023

vlimant commented Jun 5, 2023

vlimant commented Jun 5, 2023

cmsbuild commented Jun 5, 2023

RelVals

RelVals-INPUT

RelVals-NANO

vlimant commented Jun 7, 2023

vlimant commented Jun 7, 2023

cmsbuild commented Jun 7, 2023

RelVals

NANO Comparison Summary

srimanob commented Jun 12, 2023

vlimant commented Jun 13, 2023

vlimant commented Jun 13, 2023

cmsbuild commented Jun 13, 2023

cmsbuild commented Jun 13, 2023

cmsbuild commented Jun 13, 2023

Comparison Summary

NANO Comparison Summary

srimanob commented Jun 13, 2023

srimanob commented Jun 13, 2023

kskovpen commented Jun 14, 2023

cmsbuild commented Jun 14, 2023

rappoccio commented Jun 14, 2023