Change L1 2023 Relval Single Jet Bits to Current Menu Bits

[aloeliger]

PR description:

This PR is part of a (hopefully) two part series (with endcap muon fixes) to remove L1 log spam warnings. This removes old unused prescaled bits seen missing in 2023 relvals, and replaces them with L1 DPG/Menu group suggested bits

In theory, this should close L1T issue tracker cms-l1t-offline#1136

PR validation:

Workflow 141.008 was run and step 3 logs no longer complain about missing single jet bits.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, and will likely not need backporting.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41972/35935

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @aloeliger (Andrew Loeliger) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb7d2f/33181/summary.html
COMMIT: 9b3ab92
CMSSW: CMSSW_13_2_X_2023-06-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41972/33181/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 18 lines to the logs
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 17
• DQMHistoTests: Total nulls: 16
• DQMHistoTests: Total successes: 3196007
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.164 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.164 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 12434.0,... ): 0.328 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 312.0 ): 0.164 KiB L1T/L1TStage2uGT
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• diffs in HLT/SiStrip appears to be unrelated to this PR
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-06-15-1100+bb7d2f/57514/12434.0_TTbar_14TeV+2023/HLT_SiStrip_ControlView.html
• null comparison in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-06-15-1100+bb7d2f/57514/138.5_ExpressCollisions2021/L1T_L1TStage2uGT_timing_aux.html is spurious and caused by change in trigger paths

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

Not all warnings are removed in 2023 wfs, e.g. here.

%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 15-Jun-2023 15:50:21 CEST  Run: 1 Stream: 0
Algo "L1_ETT1200" not found in the trigger menu L1Menu_Collisions2023_v1_2_0. Could not retrieve algo bit number.
%MSG

In addition, new warnings are introduced in 2022 wfs, e.g. here.

%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 15-Jun-2023 15:46:42 CEST  Run: 1 Stream: 0
Algo "L1_SingleJet35_FWD2p5" not found in the trigger menu L1Menu_Collisions2022_v1_4_0. Could not retrieve algo bit number.
%MSG

[aloeliger]

Not all warnings are removed in 2023 wfs, e.g. here.

%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 15-Jun-2023 15:50:21 CEST  Run: 1 Stream: 0
Algo "L1_ETT1200" not found in the trigger menu L1Menu_Collisions2023_v1_2_0. Could not retrieve algo bit number.
%MSG

In addition, new warnings are introduced in 2022 wfs, e.g. here.

%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 15-Jun-2023 15:46:42 CEST  Run: 1 Stream: 0
Algo "L1_SingleJet35_FWD2p5" not found in the trigger menu L1Menu_Collisions2022_v1_4_0. Could not retrieve algo bit number.
%MSG

ETT1200 Can likely be replaced with something else, I can ask the Menu team and DPG again. Trying to maintain perfect consistency between 2022 and 2023 is going to be a little harder.

[aloeliger]

According to the menu group, we can probably replace ETT1200 with ETT1600. I can make that change quickly.

[missirol]

Trying to maintain perfect consistency between 2022 and 2023 is going to be a little harder.

It's understood that the L1T menu can change from year to year. I'm just pointing out that the approach in this PR can fix the 2023 wfs, but it does not really address the issue, because the same exact DQM module continues to run in wfs with different L1T menus (2022, 2023, etc). Suggestions to improve this were mentioned in #41629 (comment) and #41629 (comment).

[aloeliger]

Trying to maintain perfect consistency between 2022 and 2023 is going to be a little harder.

It's understood that the L1T menu can change from year to year. I'm just pointing out that the approach in this PR can fix the 2023 wfs, but it does not really address the issue, because the same exact DQM module continues to run in wfs with different L1T menus (2022, 2023, etc). Suggestions to improve this were mentioned in #41629 (comment) and #41629 (comment).

Alright, understood. In the meanwhile, this is available to clean the 2023 relval logs if desired. I just removed ETT1200 for ETT1600 as well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41972/35952

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #41972 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb7d2f/33203/summary.html
COMMIT: 3e8b7d3
CMSSW: CMSSW_13_2_X_2023-06-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41972/33203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 27 lines to the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 16
• DQMHistoTests: Total successes: 3196008
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.6559999999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.164 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 12434.0,... ): 0.492 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 312.0 ): 0.164 KiB L1T/L1TStage2uGT
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1