EMTF muon shower unpacker update

[eyigitba]

PR description:

This PR fixes a bunch of things in muon shower unpacking in EMTF. It's not critical for data taking, but it will be good to backport it so we can improve monitoring of this trigger for 2023.

The changes are as follows:

• Changed the internal name of the trigger from HMT to "muon shower" or "MUS". This is done for consistency with other L1T trigger producers
• Added a proper way of creating CSCShowerDigi in EMTF unpacker. This was mostly done to adjust the BX value associated with the shower (but also follows the same pattern with other EMTF inputs)
• Added support for new loose shower bit in unpacked EMTF outputs
• Removed pure muon shower objects from EMTF hit and track collections. This should fix the unnecessary LogWarning messages originating from EMTF unpacker or emulator

There will be a PR to include the BX value in EMTF emulator (and potentially uGMT as well) in the future, but for now I wanted to keep these separate.

This PR will be backported to 13_0_X and 13_1_X.

PR validation:

Validated by runTheMatrix.py -l limited -i all --ibeos as well as unpacking a recent run and validating that the correct shower bits are being unpacked at each stage.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

FYI: @elfontan @fmanteca @kakwok

[aloeliger]

@eyigitba Thanks for this.

Weirdly, you seem to have escaped buildbot's notice. Never seen that happen before.

[aloeliger]

There we go. Just needed someone to trigger a webhook.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41993/35960

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

• DataFormats/L1TMuon (l1)
• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@JanFSchulte, @rovere, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34987a/33211/summary.html
COMMIT: 8913c8b
CMSSW: CMSSW_13_2_X_2023-06-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41993/33211/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196031
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1