[DBG] Fix comparison of integer expressions of different signedness

[smuzaffar]

Fixes #42331

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42405/36419

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mroguljic, @missirol, @dkotlins, @ferencek, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test for CMSSW_13_3_DBG_X
(just to see if compilation/build issue is fixed)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8da3/33949/summary.html
COMMIT: 6315318
CMSSW: CMSSW_13_3_X_2023-07-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42405/33949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150793
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8da3/33953/summary.html
COMMIT: 6315318
CMSSW: CMSSW_13_3_DBG_X_2023-07-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42405/33953/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 23234.0

----- Begin Fatal Exception 28-Jul-2023 15:14:53 CEST-----------------------
An exception of category 'Invalid DetId' occurred while
   [0] Calling method for module HGCalBackendLayer1Producer/'l1tHGCalBackEndLayer1Producer'
   [1] Prefetching for EventSetup module HGCalTriggerGeometryESProducer/'l1tHGCalTriggerGeometryESProducer'
   [2] Calling method for EventSetup module HGCalGeometryESProducer/'HFNoseGeometryESProducer'
Exception Message:
Cannot initialize HGCSiliconDetId from 6c8bd800
----- End Fatal Exception -------------------------------------------------

AddOn Tests

• hlt_mc_HIon

----- Begin Fatal Exception 28-Jul-2023 12:02:45 CEST-----------------------
An exception of category 'CorruptedData' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 5 stream: 3
   [1] Running path 'HLT_HIMinimumBias_v4'
   [2] Calling method for module SiStripClusters2ApproxClusters/'hltSiStripClusters2ApproxClusters'
Exception Message:
[SiStripNoises::getNoise] looking for SiStripNoises for a strip out of range: strip 512
----- End Fatal Exception -------------------------------------------------

• hlt_mc_HIon

----- Begin Fatal Exception 28-Jul-2023 12:03:52 CEST-----------------------
An exception of category 'CorruptedData' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 6 stream: 2
   [1] Running path 'HLT_HIRandom_v4'
   [2] Calling method for module SiStripClusters2ApproxClusters/'hltSiStripClusters2ApproxClusters'
Exception Message:
[SiStripNoises::getNoise] looking for SiStripNoises for a strip out of range: strip 768
----- End Fatal Exception -------------------------------------------------

• hlt_data_HIon

----- Begin Fatal Exception 28-Jul-2023 11:30:09 CEST-----------------------
An exception of category 'CorruptedData' occurred while
   [0] Processing  Event run: 362321 lumi: 231 event: 111758106 stream: 0
   [1] Running path 'HLT_HIZeroBias_v6'
   [2] Calling method for module SiStripClusters2ApproxClusters/'hltSiStripClusters2ApproxClusters'
Exception Message:
[SiStripNoises::getNoise] looking for SiStripNoises for a strip out of range: strip 512
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_data_HIon

[smuzaffar]

@cms-sw/reconstruction-l2 , can you please review this. This is to fix the DBG IBs build issues. The Pr results for production arch are available #42405 (comment)

[mandrenguyen]

@smuzaffar Were you expecting all these failing tests?

[mmusich]

Were you expecting all these failing tests?

I think one does:

• in [DBG] Exception of category Invalid DetId in RelVal wf 23234.0 #41088 already / seen reported

----- Begin Fatal Exception 28-Jul-2023 15:14:53 CEST-----------------------
An exception of category 'Invalid DetId' occurred while
   [0] Calling method for module HGCalBackendLayer1Producer/'l1tHGCalBackEndLayer1Producer'
   [1] Prefetching for EventSetup module HGCalTriggerGeometryESProducer/'l1tHGCalTriggerGeometryESProducer'
   [2] Calling method for EventSetup module HGCalGeometryESProducer/'HFNoseGeometryESProducer'
Exception Message:
Cannot initialize HGCSiliconDetId from 6c8bd800
----- End Fatal Exception -------------------------------------------------

• in [DBG_X] RelVal 140.58 Step 2: Corrupted data in SiStripNoises::getNoise #42162 already seen / reported

----- Begin Fatal Exception 28-Jul-2023 11:30:09 CEST-----------------------
An exception of category 'CorruptedData' occurred while
   [0] Processing  Event run: 362321 lumi: 231 event: 111758106 stream: 0
   [1] Running path 'HLT_HIZeroBias_v6'
   [2] Calling method for module SiStripClusters2ApproxClusters/'hltSiStripClusters2ApproxClusters'
Exception Message:
[SiStripNoises::getNoise] looking for SiStripNoises for a strip out of range: strip 512
----- End Fatal Exception -------------------------------------------------

[smuzaffar]

yes @mandrenguyen , this PR only fixes the build part. relval failures need more fixes as mentioned #42405 (comment)

[mandrenguyen]

+1
Ok I see what this is about now. Thanks @smuzaffar and @mmusich for the explanations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1