fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-#41632 [13_2_X]

[missirol]

backport of #42410

PR description:

From the description of #42410:

#41632 made the VCal-to-NumberOfElectrons conversion factors of the GPU pixel unpacker configurable from the python interface. Since their default values for Phase-1 are valid for Run 2 (and not for Run 3), the Run-3 HLT menus became silently misconfigured as a result. This PR fixes that with a customisation function. The HLT menus will eventually be configured correctly in ConfDB, once HLT-menu development moves to the 13_2_X cycle.

In addition, the configuration parameter isRun2 is removed from the plugin template SiPixelRawToClusterCUDAT, as #41632 made it unnecessary.

PR validation:

addOnTests.py passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42410

Development of HLT menus for 2023 and beyond.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @missirol, @mandrenguyen, @clacaputo, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@mtosi, @mroguljic, @VourMa, @silviodonato, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-#41632 #42410

[missirol]

type bugfix

[missirol]

urgent

This fix should be included in CMSSW_13_2_0.

[missirol]

enable gpu

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fd34c/33962/summary.html
COMMIT: d81614b
CMSSW: CMSSW_13_2_X_2023-07-28-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42411/33962/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3195634
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3195612
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 40086
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 40065
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: found differences in 2 / 2 workflows

[missirol]

+hlt

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[Martin-Grunewald]

Sorry to come back to this, but what about
process.hltCTPPSPixelClusters = cms.EDProducer( "CTPPSPixelClusterProducer",

process.hltCTPPSPixelClusters = cms.EDProducer( "CTPPSPixelClusterProducer",
   RPixVerbosity = cms.untracked.int32( 0 ),
   tag = cms.InputTag( "hltCTPPSPixelDigis" ),
   SeedADCThreshold = cms.int32( 2 ),
   ADCThreshold = cms.int32( 2 ),
   ElectronADCGain = cms.double( 135.0 ),
   VCaltoElectronGain = cms.int32( 50 ),
   VCaltoElectronOffset = cms.int32( -411 ),
   doSingleCalibration = cms.bool( False )
)

[mmusich]

Sorry to come back to this, but what about

this is CT-PPS, not SIPixel...

[Martin-Grunewald]

OK, so RP pixels, not SiPixels (for use with CTPPS activity)...