-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the SFINAE check with static_assert [13.2.x] #42426
Replace the SFINAE check with static_assert [13.2.x] #42426
Conversation
Works around a rare bug in nvcc/gcc that causes a function-static variable to be emitted as a local symbol instead of a unique global symbol.
type bugfix |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_2_X. It involves the following packages:
@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport #42425 |
please test |
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
I assume the |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7401d5/34012/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Works around a rare bug in nvcc/gcc that causes a function-static variable to be emitted as a local symbol instead of a unique global symbol.
PR validation:
Adding these changes on top of a setup that is failing as described in #42414 prevents the crash at the end of the job.
PR backports:
Backport of #42425 to 13.2.x to fix Alpaka-related developments and workflows.