[CPP20] Fix compilation issue in cmssw/DataFormats/HcalDigi/test/test_hcal_digi.cu #42755

iarspider · 2023-09-12T08:08:01Z

PR description:

Fixes #42624 as suggested by @makortel in #42624 (comment)

PR validation:

Bot tests.

iarspider · 2023-09-12T08:10:10Z

test parameters:

addpkg = DataFormats/HcalDigi,DataFormats/Common

cmsbuild · 2023-09-12T08:13:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42755/36850

This PR adds an extra 20KB to repository

cmsbuild · 2023-09-12T08:14:01Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

DataFormats/Common (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2023-09-12T08:14:41Z

please test for CMSSW_13_3_CPP20_X

iarspider · 2023-09-12T08:15:09Z

please test

cmsbuild · 2023-09-12T09:20:23Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34705/summary.html
COMMIT: 70c0b1a
CMSSW: CMSSW_13_3_X_2023-09-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42755/34705/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building LCG reflex dict from header file src/DataFormats/FTLDigi/src/classes.h
Warning: Unused class rule: edm::Wrapper
Warning: Unused class rule: edm::Wrapper
Warning: Unused class rule: edm::Wrapper
Warning: Unused class rule: edm::Wrapper
gmake: *** [tmp/el8_amd64_gcc11/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/el8_amd64_gcc11/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc
cc1plus: fatal error: DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc: No such file or directory
compilation terminated.
gmake: *** [tmp/el8_amd64_gcc11/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc.o] Error 1
mv: cannot stat 'tmp/el8_amd64_gcc11/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc.dx': No such file or directory

cmsbuild · 2023-09-12T09:29:50Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34704/summary.html
COMMIT: 70c0b1a
CMSSW: CMSSW_13_3_CPP20_X_2023-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42755/34704/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34704/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34704/git-merge-result

Build

I found compilation error when building:

>> Building LCG reflex dict from header file src/DataFormats/FTLDigi/src/classes.h
Warning: Unused class rule: edm::Wrapper
Warning: Unused class rule: edm::Wrapper
Warning: Unused class rule: edm::Wrapper
Warning: Unused class rule: edm::Wrapper
gmake: *** [tmp/el8_amd64_gcc12/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/el8_amd64_gcc12/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc
cc1plus: fatal error: DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc: No such file or directory
compilation terminated.
gmake: *** [tmp/el8_amd64_gcc12/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc.o] Error 1
mv: cannot stat 'tmp/el8_amd64_gcc12/src/DataFormats/FTLDigi/src/DataFormatsFTLDigi/a/DataFormatsFTLDigi_xr.cc.dx': No such file or directory

iarspider · 2023-09-12T09:49:36Z

please test for CMSSW_13_3_CPP20_X

cmsbuild · 2023-09-12T10:01:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42755/36853

This PR adds an extra 28KB to repository

cmsbuild · 2023-09-12T14:33:02Z

Pull request #42755 was updated. @smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @AdrianoDee, @srimanob, @jfernan2, @mandrenguyen can you please check and sign again.

cmsbuild · 2023-09-12T21:52:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34711/summary.html
COMMIT: fdf574d
CMSSW: CMSSW_13_3_CPP20_X_2023-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42755/34711/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34711/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34711/git-merge-result

Comparison Summary

Summary:

You potentially added 7990 lines to the logs
Reco comparison results: 13785 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3003539
DQMHistoTests: Total failures: 34857
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2968659
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 200 log files, 150 edm output root files, 46 DQM output files
TriggerResults: no differences found

makortel · 2023-09-12T22:22:57Z

@cmsbuild, please test

Let's run normal tests as well

cmsbuild · 2023-09-13T04:51:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b5d7c/34726/summary.html
COMMIT: fdf574d
CMSSW: CMSSW_13_3_X_2023-09-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42755/34726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 21 lines to the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3348561
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3348536
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

makortel · 2023-09-13T13:10:54Z

+core

jfernan2 · 2023-09-14T07:40:43Z

+1

civanch · 2023-09-14T10:29:55Z

+1

srimanob · 2023-09-18T11:48:36Z

+Upgrade

Technical PR.

cmsbuild · 2023-09-18T11:48:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2023-09-18T15:28:03Z

+1

Apply suggested fix for cms-sw#42624

70c0b1a

cmsbuild added this to the CMSSW_13_3_X milestone Sep 12, 2023

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 12, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 12, 2023

cmsbuild added tests-started and removed tests-pending labels Sep 12, 2023

cmsbuild added tests-rejected and removed tests-started labels Sep 12, 2023

Add missing includes

e830625

cmsbuild added reconstruction-pending tests-pending code-checks-pending tests-started and removed tests-rejected code-checks-approved tests-pending labels Sep 12, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 12, 2023

cmsbuild added tests-started and removed tests-approved labels Sep 12, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 13, 2023

cmsbuild added core-approved and removed core-pending labels Sep 13, 2023

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 14, 2023

cmsbuild added simulation-approved and removed simulation-pending labels Sep 14, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 18, 2023

cmsbuild added orp-approved and removed orp-pending labels Sep 18, 2023

cmsbuild merged commit 5f7bab8 into cms-sw:master Sep 18, 2023

iarspider deleted the fix-42624 branch September 20, 2023 06:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CPP20] Fix compilation issue in cmssw/DataFormats/HcalDigi/test/test_hcal_digi.cu #42755

[CPP20] Fix compilation issue in cmssw/DataFormats/HcalDigi/test/test_hcal_digi.cu #42755

iarspider commented Sep 12, 2023

iarspider commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

iarspider commented Sep 12, 2023

iarspider commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

iarspider commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

makortel commented Sep 12, 2023

cmsbuild commented Sep 13, 2023

makortel commented Sep 13, 2023

jfernan2 commented Sep 14, 2023

civanch commented Sep 14, 2023

srimanob commented Sep 18, 2023

cmsbuild commented Sep 18, 2023

antoniovilela commented Sep 18, 2023

[CPP20] Fix compilation issue in cmssw/DataFormats/HcalDigi/test/test_hcal_digi.cu #42755

[CPP20] Fix compilation issue in cmssw/DataFormats/HcalDigi/test/test_hcal_digi.cu #42755

Conversation

iarspider commented Sep 12, 2023

PR description:

PR validation:

iarspider commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

iarspider commented Sep 12, 2023

iarspider commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

Build

cmsbuild commented Sep 12, 2023

Build

iarspider commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

Comparison Summary

makortel commented Sep 12, 2023

cmsbuild commented Sep 13, 2023

Comparison Summary

makortel commented Sep 13, 2023

jfernan2 commented Sep 14, 2023

civanch commented Sep 14, 2023

srimanob commented Sep 18, 2023

cmsbuild commented Sep 18, 2023

antoniovilela commented Sep 18, 2023