-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx346Y Fix the compilation error in CaloSD for debug mode #43016
Conversation
type BugFix |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43016/37187
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43016/37188
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5322/35188/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
It is the fix of #43015 |
@cmsbuild Please test |
Just resolved the conflicts
…________________________________
From: rappoccio ***@***.***>
Sent: 16 October 2023 21:59
To: cms-sw/cmssw ***@***.***>
Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***>
Subject: Re: [cms-sw/cmssw] Phase2-hgx346Y Fix the compilation error in CaloSD for debug mode (PR #43016)
@bsunanda<https://github.com/bsunanda> there are conflicts here, can you fix them? thanks.
—
Reply to this email directly, view it on GitHub<#43016 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOUYCNMEBLBQV5XSYMTX7VOE5AVCNFSM6AAAAAA57M23AGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUHA2TCMJYGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43016/37207
|
Pull request #43016 was updated. @mdhildreth, @civanch can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5322/35213/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fix the compilation error in CaloSD for debug mode
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special