Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.3.X] remove HLT tracking and vertexing validation harvesting from phase-2 exclusion modifier #43417

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 28, 2023

backport of #43330

PR description:

Title says it all, address #39362 (comment)

PR validation:

runTheMatrix.py -l 24834.0 -t 4 -j 8 --ibeos runs fine

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #43330 to 13.3.X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • HLTriggerOffline/Common (dqm)

@syuvivida, @nothingface0, @rvenditti, @tjavaid, @antoniovagnerini, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bee80/36119/summary.html
COMMIT: e57c10a
CMSSW: CMSSW_13_3_X_2023-11-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43417/36119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 393 lines from the logs
  • Reco comparison results: 134 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3360156
  • DQMHistoTests: Total failures: 2487
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357647
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 388.37399999999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 41.775 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 23234.0,... ): 22.953 KiB HLT/Tracking
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Nov 28, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 08cfb10 into cms-sw:CMSSW_13_3_X Nov 28, 2023
10 checks passed
@mmusich mmusich deleted the mm_devel_addHarvesting_to_Phase2HLT_13_3_X branch November 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants