Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholders of phase2 geometry config files #43476

Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Dec 1, 2023

PR description:

As discussed in #42945, we currently have obsolete config files which can't run because geometry config is old. This PR introduces the default config file so that any scripts which do not need specific geometry can use. Those scripts will be forwarded port every time we update the baseline. No change on geometry-specific configs.

PR validation:

No test. No change is expected as the introduced configs are not used anywhere.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43476/38038

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)

@mdhildreth, @cmsbuild, @bsunanda, @Dr15Jones, @civanch, @srimanob, @makortel can you please review it and eventually sign? Thanks.
@slomeo, @Martin-Grunewald, @fabiocos, @vargasa, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Dec 1, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06cd8b/36267/summary.html
COMMIT: 22ca618
CMSSW: CMSSW_14_0_X_2023-12-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43476/36267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3370032
  • DQMHistoTests: Total failures: 75
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3369935
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Dec 2, 2023

+Upgrade

No change is expected from this PR. After this PR is merged, I will scan obsolete configs, i.e. D49 and migrate them to Default Geometry if possible.

@civanch
Copy link
Contributor

civanch commented Dec 2, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants