Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable mkFit for pixelLess iteration #43815

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jan 30, 2024

This is a provisional PR, awaiting feedback from the 14_0_0_pre2 special validation campaign.

Some relval progress is available in https://its.cern.ch/jira/browse/PDMVRELVALS-227

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43815/38623

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/Eras (operations)

@rappoccio, @davidlange6, @cmsbuild, @antoniovilela, @fabiocos can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @fabiocos, @AnnikaStein, @makortel this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Jan 30, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a19f0/37114/summary.html
COMMIT: eb911ff
CMSSW: CMSSW_14_0_X_2024-01-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43815/37114/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a19f0/37114/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a19f0/37114/git-merge-result

Comparison Summary

Summary:

  • You potentially added 33 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 29631 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248611
  • DQMHistoTests: Total failures: 23617
  • DQMHistoTests: Total nulls: 17
  • DQMHistoTests: Total successes: 3224955
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.6 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.023 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.043 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.062 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042,... ): 0.182 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042 ): 0.047 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.074 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@slava77
Copy link
Contributor Author

slava77 commented Jan 31, 2024

@cmsbuild please test

to get cleaner comparisons without the extra commits (lastIB...thisPR)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a19f0/37138/summary.html
COMMIT: eb911ff
CMSSW: CMSSW_14_0_X_2024-01-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43815/37138/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 55 lines from the logs
  • Reco comparison results: 28633 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248620
  • DQMHistoTests: Total failures: 17691
  • DQMHistoTests: Total nulls: 17
  • DQMHistoTests: Total successes: 3230890
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.05500000000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.023 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.043 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.062 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.047 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.074 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024
@antoniovilela
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

@smuzaffar
Hi Shahzad, this PR and others remained with milestone CMSSW_14_0_X. Do you understand what happened?
Thanks.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 12, 2024
@antoniovilela
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

@smuzaffar Hi Shahzad, this PR and others remained with milestone CMSSW_14_0_X. Do you understand what happened? Thanks.

It seems to have picked up the milestone after my comment?

@smuzaffar
Copy link
Contributor

no idea why bot did not process these PR when I opened 14.1.X release cycle.
Anyway, you can just comment of such PRs and bot will fix the milestone

@antoniovilela
Copy link
Contributor

no idea why bot did not process these PR when I opened 14.1.X release cycle. Anyway, you can just comment of such PRs and bot will fix the milestone

Ok, then it will resolve itself once people comment.

@smuzaffar
Copy link
Contributor

@antoniovilela , yes a lot of PRs of master branch were still on 14.0.X milestone. I have re-run bot to process all those and they should have correct milestone now. I will check why it did not work when I opened 14.1.X

@antoniovilela
Copy link
Contributor

@antoniovilela , yes a lot of PRs of master branch were still on 14.0.X milestone. I have re-run bot to process all those and they should have correct milestone now. I will check why it did not work when I opened 14.1.X

Thanks a lot Shahzad.

@rappoccio
Copy link
Contributor

hold

  • Validation not completed yet, still needs to be checked by PDMV.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2024

type tracking

@antoniovilela
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Apr 9, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit a243e90 into cms-sw:master Apr 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants