Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X backport] Produce sMajor, sMinor in EgammaHLTClusterShapeProducer #43908

Merged

Conversation

swagata87
Copy link
Contributor

Backport of #43885
Useful for phase2 HLT studies of displaced e/gamma paths.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoEgamma/EgammaHLTProducers (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@silviodonato, @sameasy, @sobhatta, @lgray, @cericeci, @Martin-Grunewald, @ram1123, @jainshilpi, @Prasant1993, @varuns23, @missirol, @HuguesBrun, @a-kapoor, @Sam-Harper, @Fedespring, @afiqaize, @valsdav this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a66aa2/37302/summary.html
COMMIT: 59bcf97
CMSSW: CMSSW_14_0_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43908/37302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@swagata87 swagata87 force-pushed the 140X_circularityVarsForDisplacedEg branch from 59bcf97 to 1663d7d Compare February 11, 2024 14:30
@cmsbuild
Copy link
Contributor

Pull request #43908 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #43908 was updated. @mmusich, @cmsbuild, @Martin-Grunewald can you please check and sign again.

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a66aa2/37344/summary.html
COMMIT: 77e55cf
CMSSW: CMSSW_14_0_X_2024-02-11-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43908/37344/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 564a773 into cms-sw:CMSSW_14_0_X Feb 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants