Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Fix deprecated-copy warnings in PowerPC and AArch64 builds:

  .../src/DataFormats/L1THGCal/interface/HGCalClusterT.h:292:23: warning: implicitly-declared 'constexpr Basic3DVector<float>& Basic3DVector<float>::operator=(const Basic3DVector<float>&)' is deprecated [-Wdeprecated-copy]
   292 |         clusterCentre = clusterCentre * mipPt_ + constituentCentre * cMipt;
      |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from .../src/DataFormats/GeometryVector/interface/Basic3DVector.h:7,
                 from .../src/DataFormats/GeometryVector/interface/PV3DBase.h:4,
                 from .../src/DataFormats/GeometryVector/interface/Point3DBase.h:5,
                 from .../src/DataFormats/GeometryVector/interface/GlobalPoint.h:5,
                 from .../src/DataFormats/L1THGCal/interface/HGCalTriggerCell.h:4,
                 from .../src/DataFormats/L1THGCal/interface/HGCalCluster.h:6:
.../src/DataFormats/GeometryVector/interface/private/extBasic3DVector.h:46:3: note: because 'Basic3DVector<float>' has user-provided 'Basic3DVector<T>::Basic3DVector(const Basic3DVector<T>&) [with T = float]'
   46 |   Basic3DVector(const Basic3DVector& p) : v(p.v) {}
      |   ^~~~~~~~~~~~~
In file included from .../src/DataFormats/L1THGCal/interface/HGCalMulticluster.h:6,
                 from src/DataFormats/L1THGCal/src/HGCalMulticluster.cc:1:
.../src/DataFormats/L1THGCal/interface/HGCalClusterT.h: In instantiation of 'void l1t::HGCalClusterT<C>::updateP4AndPosition(const edm::Ptr<T>&, bool, float) [with C = l1t::HGCalCluster]':
.../src/DataFormats/L1THGCal/interface/HGCalClusterT.h:66:7:   required from 'void l1t::HGCalClusterT<C>::addConstituent(const edm::Ptr<T>&, bool, float) [with C = l1t::HGCalCluster]'
.../src/DataFormats/L1THGCal/interface/HGCalClusterT.h:44:7:   required from 'l1t::HGCalClusterT<C>::HGCalClusterT(const edm::Ptr<T>&, float) [with C = l1t::HGCalCluster]'
src/DataFormats/L1THGCal/src/HGCalMulticluster.cc:9:96:   required from here
  .../src/DataFormats/L1THGCal/interface/HGCalClusterT.h:292:23: warning: implicitly-declared 'constexpr Basic3DVector<float>& Basic3DVector<float>::operator=(const Basic3DVector<float>&)' is deprecated [-Wdeprecated-copy]
   292 |         clusterCentre = clusterCentre * mipPt_ + constituentCentre * cMipt;
      |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from .../src/DataFormats/GeometryVector/interface/Basic3DVector.h:7,
                 from .../src/DataFormats/GeometryVector/interface/PV3DBase.h:4,
                 from .../src/DataFormats/GeometryVector/interface/Point3DBase.h:5,
                 from .../src/DataFormats/GeometryVector/interface/GlobalPoint.h:5,
                 from .../src/DataFormats/L1THGCal/interface/HGCalClusterT.h:6:
.../src/DataFormats/GeometryVector/interface/private/extBasic3DVector.h:46:3: note: because 'Basic3DVector<float>' has user-provided 'Basic3DVector<T>::Basic3DVector(const Basic3DVector<T>&) [with T = float]'
   46 |   Basic3DVector(const Basic3DVector& p) : v(p.v) {}
      |   ^~~~~~~~~~~~~

Same fix as in #43460, but for extBasic{2,3}DVector instead of sseBasic{2,3}DVector.

PR validation:

Local tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for el8_ppc64le_gcc12

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44448/39518

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DataFormats/GeometryVector (simulation)

@mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@rovere, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for el8_ppc64le_gcc12

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec554a/38216/summary.html
COMMIT: c4fd9d9
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44448/38216/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec554a/38214/summary.html
COMMIT: c4fd9d9
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44448/38214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec554a/38219/summary.html
COMMIT: c4fd9d9
CMSSW: CMSSW_14_1_X_2024-03-15-2300/el8_ppc64le_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44448/38219/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec554a/38219/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec554a/38219/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testPhysicsToolsSelectorUtilsPythonTestsDriver had ERRORS

@iarspider
Copy link
Contributor Author

iarspider commented Mar 18, 2024 via email

@civanch
Copy link
Contributor

civanch commented Mar 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants