Phase 2 Bugfix: add the TkJetWord ValidBit to match Firmware #45065
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45065/40378
|
|
A new Pull Request was created by @NJManganelli for master. It involves the following packages:
@epalencia, @cmsbuild, @subirsarkar, @aloeliger, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45065/40502
|
|
Pull request #45065 was updated. @cmsbuild, @subirsarkar, @srimanob, @epalencia, @aloeliger can you please check and sign again. |
|
@NJManganelli What is the status of this PR, is it ready to come out of draft? |
Connor discovered an issue with the eta range between emulation and firmware, and we began adding fixes for it into this PR. There's more work needed to complete that portion, and we were thinking the validBit fix by itself (given these additional problems) is not really useful in the GTT group, but if there's reason to, those eta fixes can be spun off into a separate PR. |
NJManganelli
force-pushed
the
master-updatetrackjets
branch
from
6b39d9c to
91fe72e
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45065/41004 |
|
Pull request #45065 was updated. @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again. |
|
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
|
ping (to make bot change milestone) |
|
Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X. |
PR description:
This PR adds a missing validBit to the TkJetWord's 128bit word, needed for Integration Tests between Global Track Trigger and Global Trigger.
PR validation:
This PR passes:
scram b code-checks
scram b code-format
scram b
runTheMatrix.py -l limited -i all --ibeos [output:
exit: 0 256 0 46 3 0 0 0 0 0 0 0 0 0 tests passed, 2 42 3 0 0 0 0 0 0 0 0 failed (The number of "failed" tests looks like ones I've seen before locally... ) ]
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR may need a backport to the cms-l1t-offline Phase 2 Integration Branch (the "may": if that will still be maintained)