Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Workaround to produce exactly same data products in Serial and CUDA backends in Alpaka modules possibly used at HLT" #45080

Conversation

makortel
Copy link
Contributor

PR description:

Reverts #44698, to be used in conjunction with #44892

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X

…d CUDA backends in Alpaka modules possibly used at HLT"
@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45080/40396

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • EventFilter/EcalRawToDigi (reconstruction)
  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoParticleFlow/PFRecHitProducer (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)
  • RecoTracker/PixelVertexFinding (reconstruction)
  • RecoVertex/BeamSpotProducer (alca, reconstruction)

@mandrenguyen, @fwyzard, @perrotta, @consuegs, @saumyaphor4252, @makortel, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@tvami, @Martin-Grunewald, @fabiocos, @yuanchao, @lgray, @apsallid, @ferencek, @francescobrivio, @mmusich, @ReyerBand, @missirol, @JanFSchulte, @tocheng, @GiacomoSguazzoni, @sameasy, @hatakeyamak, @rsreds, @dkotlins, @thomreis, @gpetruc, @mmarionncern, @mtosi, @tsusa, @rovere, @VourMa, @youyingli, @seemasharmafnal, @felicepantaleo, @threus, @argiro, @mroguljic, @rchatter, @dgulhan, @VinInn, @wang0jin this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

enable gpu

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e688db/39585/summary.html
COMMIT: 651f600
CMSSW: CMSSW_14_1_X_2024-05-28-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45080/39585/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3445370
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3445347
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39717
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

@jfernan2
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

@rappoccio
Copy link
Contributor

Skipping tests and bypassing signatures.

@cmsbuild cmsbuild merged commit 76fee6d into cms-sw:master May 29, 2024
14 checks passed
@makortel makortel deleted the revert-44698-productIDModuleTypeResolverWorkaround branch May 29, 2024 15:41
@fwyzard
Copy link
Contributor

fwyzard commented Jun 20, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants