Modifications to L1REPACK:FullSimTP to prevent crashes and make it more compatible with other REPACK options

[eyigitba]

PR description:

This PR started as a modification to L1REPACK:FullSimTP to prevent a crash due to missing GEM unpacker. However, while going through the config I realized some outdated options which I ended up removing. This config was already modifed to work only with L1T Stage-2 options, so there was no reason to keep around CSCTF/DTTF options.

Furthermore, I am changing the config for now to use unpacked muon TF inputs instead of calling muon TP re-emulation modules. This is mostly done to bypass a problem I observe in DT TP re-emulation that causes lower rates. I kept the muon TP re-emulation options in place to allow people to switch quickly between the two options.

PR validation:

I validated by running L1REPACK:uGT and L1REPACK:FullSimTP and comparing them. There are no crashes and the final rates are comparable up to re-emulation level mismatches.

The normal CMSSW workflows are probably no enough to check this PR, otherwise the crash would have been caught before.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

I think we will backport this to 14_0_X in case we need to use it again in this year's data workflows. It's not urgent, so I would wait until the discussion on this PR is settled.

FYI @missirol

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45132/40472

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

• Configuration/StandardSequences (operations)

@antoniovilela, @davidlange6, @fabiocos, @rappoccio, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @rovere, @VourMa, @VinInn, @makortel, @GiacomoSguazzoni, @JanFSchulte, @dgulhan, @mmusich, @Martin-Grunewald, @fabiocos, @felicepantaleo, @sameasy, @slomeo this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

Small point: iiuc, GEM has its own modifier, so maybe something like the following should be done.

cmssw/Configuration/StandardSequences/python/SimL1EmulatorRepack_Full_cff.py

Lines 157 to 165 in 1e7c61e

	SimL1EmulatorTask = cms.Task()
	stage2L1Trigger.toReplaceWith(SimL1EmulatorTask, cms.Task(unpackEcal,unpackHcal,unpackCSC,unpackDT,unpackRPC,unpackRPCTwinMux,unpackTwinMux,unpackOmtf,unpackEmtf,unpackCsctf,unpackBmtf
	,unpackTcds
	,SimL1EmulatorCoreTask,packCaloStage2
	,packGmtStage2,packGtStage2,rawDataCollector))
	_SimL1EmulatorTaskWithGEM = SimL1EmulatorTask.copy()
	_SimL1EmulatorTaskWithGEM.add(unpackGEM)
	(stage2L1Trigger & run3_GEM).toReplaceWith(SimL1EmulatorTask, _SimL1EmulatorTaskWithGEM)

[eyigitba]

Thanks Marino. I think this makes more sense to decouple Stage-2 and Run 3. I'll change it now

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45132/40477

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #45132 was updated. @rappoccio, @davidlange6, @cmsbuild, @fabiocos, @antoniovilela can you please check and sign again.

[missirol]

@eyigitba

Thanks for this update ! Indeed, I think it would be useful to backport it to 14_0_X.

[eyigitba]

Thanks @missirol ! I'll make the backport now.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef7c7/39809/summary.html
COMMIT: adb1c01
CMSSW: CMSSW_14_1_X_2024-06-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45132/39809/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338951
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.