[ALCA] Remove Wall flag from Alignment/OfflineValidation/bin/BuildFile.xml

[iarspider]

PR description:

The -Wall flag overrides -Wno-vla-cxx-extension flag defined in in llvm-cxxcompiler and makes Clang emit warnings about variable-length array (a nonstandard C++ extension), e.g.:

In file included from src/Alignment/OfflineValidation/bin/MTSmerge.cc:20:
  src/Alignment/OfflineValidation/macros/trackSplitPlot.C:59:17: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
    59 |   Int_t lengths[n];
      |                 ^
src/Alignment/OfflineValidation/macros/trackSplitPlot.C:59:17: note: initializer of 'n' is not a constant expression
src/Alignment/OfflineValidation/macros/trackSplitPlot.C:56:15: note: declared here
   56 |   const Int_t n = nFiles;
      |               ^
  src/Alignment/OfflineValidation/macros/trackSplitPlot.C:758:13: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
   758 |   bool used[n];
      |             ^
src/Alignment/OfflineValidation/macros/trackSplitPlot.C:758:13: note: initializer of 'n' is not a constant expression
src/Alignment/OfflineValidation/macros/trackSplitPlot.C:747:13: note: declared here
  747 |   const int n = nFiles;
      |             ^
2 warnings generated.

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_CLANG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45169/40517

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@saumyaphor4252, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@adewit, @yuanchao, @tlampen, @rsreds, @mmusich, @tocheng this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3957ff/39771/summary.html
COMMIT: e08439f
CMSSW: CMSSW_14_1_CLANG_X_2024-06-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45169/39771/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 14235 lines to the logs
• Reco comparison results: 30374 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 38031
• DQMHistoTests: Total nulls: 154
• DQMHistoTests: Total successes: 3300769
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.026999999999999993 KiB( 47 files compared)
• DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.063 ): 0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): -0.020 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 4 / 46 workflows

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3957ff/39797/summary.html
COMMIT: e08439f
CMSSW: CMSSW_14_1_X_2024-06-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45169/39797/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 857
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338097
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

Quite technical PR which apparently makes clang happy without significantly affecting the Alignment/OfflineValidation package
Let me just check with @cms-sw/core-l2 if they see any counterindication in removing that flag (which enables compiler's warning messages) without replacing it with anything else...

[smuzaffar]

@perrotta , scram already pass -Wall (https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_14_1_X/master/scram-tools.file/tools/gcc/gcc-cxxcompiler.xml#L11) and then explicitly white-list some warning. Removing -Wall here is fine.

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1