Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set uGMT version used for 2024 in the packers #45180

Merged

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Jun 10, 2024

The unpacking of quantities in the uGMT unpacker is switched by the firmware version that is written in the raw data. In this PR I updated the firmware version written by the packers so that the repack workflows work as expected.

This might be needed for the central MC production (depending on whether the workflow uses repack), could you let me know if this will require a backport?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45180/40537

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinyar for master.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @eyigitba, @thomreis this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf2a1c/39810/summary.html
COMMIT: 048088c
CMSSW: CMSSW_14_1_X_2024-06-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45180/39810/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@aloeliger
Copy link
Contributor

No idea on the backport, let me get back from the US and ask around and we can let you know

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7d7fb8d into cms-sw:master Jun 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants