Unpacker and DataFormat for L1 Trigger Scouting BMTF source #45262

Mmiglio · 2024-06-18T15:41:05Z

PR description:

This PR introduces the unpacker and data format needed to process muon stubs collected with the L1 Scouting system from the BMTF Trigger processors.

New test file have been added to cms-data in this PR:

Added tests for BMTF stubs data source cms-data/DataFormats-L1Scouting#3

PR validation:

PR unpacker has been validated with data collected at p5 with the L1 scouting system, running in local, and comparing data results with L1 Trigger objects reconstructed starting from the cdaq Raw data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be discussed: We would like this PR to be backported in a data-taking release in order to collect data from pp collisions during 2024.

cmsbuild · 2024-06-18T15:41:34Z

cms-bot internal usage

cmsbuild · 2024-06-18T15:45:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45262/40639

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2024-06-18T15:45:32Z

A new Pull Request was created by @Mmiglio for master.

It involves the following packages:

DataFormats/L1Scouting (daq)
EventFilter/L1ScoutingRawToDigi (daq)

@smorovic, @emeschi, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

smorovic · 2024-06-18T15:46:47Z

@cmsbuild please test with cms-data/DataFormats-L1Scouting#3

cmsbuild · 2024-06-18T16:54:30Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c94d/39957/summary.html
COMMIT: 73d8ad2
CMSSW: CMSSW_14_1_X_2024-06-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45262/39957/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c94d/39957/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c94d/39957/git-merge-result

RelVals

RelVals-INPUT

AddOn Tests

read312RV

----- Begin Fatal Exception 18-Jun-2024 18:47:29 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02842/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-18-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py
Exception Message:
 unknown python problem occurred.
ModuleNotFoundError: No module named 'past'

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02842/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-18-1100/src/FWCore/ParameterSet/python/Types.py(6): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02842/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-18-1100/src/FWCore/ParameterSet/python/Config.py(16): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02842/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-18-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py(2): <module>

----- End Fatal Exception -------------------------------------------------

fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 0 sec (ended on Tue Jun 18 18:47:31 2024) - exit: 256

fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 0 sec (ended on Tue Jun 18 18:47:34 2024) - exit: 256

Expand to see more addon errors ...

smorovic · 2024-06-18T20:55:31Z

please test

smorovic · 2024-06-18T22:35:07Z

@cmsbuild abort tests

smorovic · 2024-06-18T22:36:23Z

@cmsbuild abort test

smorovic · 2024-06-18T22:36:54Z

@cmsbuild please abort

smorovic · 2024-06-18T22:37:38Z

@cmsbuild please test with cms-data/DataFormats-L1Scouting#3

dinyar · 2024-06-19T05:33:41Z

Adding @aloeliger and @epalencia for the L1T. This would be good to have in a backport for P5 so we can take data from the BMTF. Matteo mentioned he will join the L1T OffSW meeting today to discuss the next steps in more detail if needed.

cmsbuild · 2024-06-19T09:29:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c94d/39964/summary.html
COMMIT: 73d8ad2
CMSSW: CMSSW_14_1_X_2024-06-18-1800/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45262/39964/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c94d/39964/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12c94d/39964/git-merge-result

Comparison Summary

Summary:

You potentially added 18 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345018
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344998
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

smorovic · 2024-06-19T09:33:57Z

+1

cmsbuild · 2024-06-19T09:34:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DataFormats-L1Scouting#3

…as they are not available for older releases

antoniovilela · 2024-06-21T12:30:59Z

cms-data/DataFormats-L1Scouting#3 merged.
cmsdist tag PR: cms-sw/cmsdist#9260

antoniovilela · 2024-06-21T12:31:28Z

+1

…as they are not available for older releases

Mmiglio added 5 commits May 27, 2024 10:04

BMTF input stubs data format and first unpacker

30fb1e7

BMTF input stubs and unpacker fixes

6db2e7d

Added DataFormat tests

10c7386

Merged BMTFUnpacker from repository Mmiglio with cms-merge-topic

cf9d8d7

Added in the test script new testing file

73d8ad2

cmsbuild added this to the CMSSW_14_1_X milestone Jun 18, 2024

cmsbuild added daq-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jun 18, 2024

Mmiglio mentioned this pull request Jun 18, 2024

Added tests for BMTF stubs data source cms-data/DataFormats-L1Scouting#3

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 18, 2024

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 18, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 18, 2024

cmsbuild added tests-started and removed requires-external tests-rejected labels Jun 18, 2024

cmsbuild added tests-pending and removed tests-started labels Jun 18, 2024

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 18, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 19, 2024

cmsbuild added daq-approved fully-signed and removed daq-pending pending-signatures labels Jun 19, 2024

Mmiglio added a commit to Mmiglio/cmssw that referenced this pull request Jun 20, 2024

Backport of cms-sw#45262 - Removed test files from data format tests …

0a9b396

…as they are not available for older releases

Mmiglio mentioned this pull request Jun 20, 2024

[14_0_X Backport] Unpacker and DataFormat for L1 Trigger Scouting BMTF source #45273

Merged

cmsbuild added orp-approved and removed orp-pending labels Jun 21, 2024

cmsbuild merged commit cee02a0 into cms-sw:master Jun 21, 2024
11 checks passed

cmsbuild mentioned this pull request Jun 21, 2024

Heterogeneous Workflow (CLUE) in Phase2 HLT Simplified Menu #45178

Merged

Mmiglio deleted the BMTFUnpacker branch June 26, 2024 13:55

dbruschi pushed a commit to dbruschi/cmssw that referenced this pull request Feb 6, 2025

Backport of cms-sw#45262 - Removed test files from data format tests …

1ceb5b6

…as they are not available for older releases

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unpacker and DataFormat for L1 Trigger Scouting BMTF source #45262

Unpacker and DataFormat for L1 Trigger Scouting BMTF source #45262

Mmiglio commented Jun 18, 2024 •

edited

Loading

cmsbuild commented Jun 18, 2024 •

edited

Loading

cmsbuild commented Jun 18, 2024

cmsbuild commented Jun 18, 2024

smorovic commented Jun 18, 2024

cmsbuild commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

dinyar commented Jun 19, 2024

cmsbuild commented Jun 19, 2024

smorovic commented Jun 19, 2024

cmsbuild commented Jun 19, 2024

antoniovilela commented Jun 21, 2024

antoniovilela commented Jun 21, 2024

Unpacker and DataFormat for L1 Trigger Scouting BMTF source #45262

Unpacker and DataFormat for L1 Trigger Scouting BMTF source #45262

Conversation

Mmiglio commented Jun 18, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jun 18, 2024 • edited Loading

cmsbuild commented Jun 18, 2024

cmsbuild commented Jun 18, 2024

smorovic commented Jun 18, 2024

cmsbuild commented Jun 18, 2024

RelVals

RelVals-INPUT

AddOn Tests

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

smorovic commented Jun 18, 2024

dinyar commented Jun 19, 2024

cmsbuild commented Jun 19, 2024

Comparison Summary

smorovic commented Jun 19, 2024

cmsbuild commented Jun 19, 2024

antoniovilela commented Jun 21, 2024

antoniovilela commented Jun 21, 2024

Mmiglio commented Jun 18, 2024 •

edited

Loading

cmsbuild commented Jun 18, 2024 •

edited

Loading