Improve plugins in Alignment/HIPAlignmentAlgorithm and add unit tests

[mmusich]

PR description:

The main goal of this PR is refresh the class LhcTrackAnalyzer.cc to add more branches relevant to study track quantities.
In addition:

• added a fillDesciptions method to HIPTwoBodyDecayAnalyzer
• cleaned up unused methods
• added catch2-based unit tests to test these analyzers.

PR validation:

scram b runtests_testHIPAnalyzers runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported to CMSSW_14_0_X for data-taking purposes.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45268/40651

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• Alignment/HIPAlignmentAlgorithm (alca)

@cmsbuild, @saumyaphor4252, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@mmusich, @yuanchao, @adewit, @tocheng, @rsreds this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

alas this fails with :

----- Begin Fatal Exception 19-Jun-2024 13:45:55 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path '_test_endpath'
   [2] Calling method for module HIPTwoBodyDecayAnalyzer/'trackAnalyzer'
Exception Message:
No "TransientTrackRecord" record found in the EventSetup.

 The Record is delivered by an ESSource or ESProducer but there is no valid IOV for the synchronization value.
 Please check
   a) if the synchronization value is reasonable and report to the hypernews if it is not.
   b) else check that all ESSources have been properly configured.
----- End Fatal Exception -------------------------------------------------

Despite I explicitly add the ESProducer in the catch2 configuration:

cmssw/Alignment/HIPAlignmentAlgorithm/test/testHIPAnalyzers.cc

Lines 57 to 58 in 0eec2cb

	process.load("TrackingTools.TransientTrack.TransientTrackBuilder_cfi")
	process.add_(cms.ESProducer("TransientTrackBuilderESProducer"))

any help / hints are welcome.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45268/40653

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #45268 was updated. @saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f140c/40010/summary.html
COMMIT: 4957105
CMSSW: CMSSW_14_1_X_2024-06-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45268/40010/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345018
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344992
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

@mmusich this PR seems good to go to me.
Should I sign it for AlCa, or would you prefer waiting for the resolution of #45268 (comment) before proceeding?

[mmusich]

Should I sign it for AlCa, or would you prefer waiting for the resolution of #45268 (comment) before proceeding?

I guess it can be signed as it is, though I would be happy to implement improvements if anyone has comments on that. We can also come back to this later.

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1