-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new Online HCAL DQM histogram for bad quality events #45527
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/40995 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/40995/code-format.patch | patch -p1 is done. run scram build code-format to apply code format directly is done. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41036 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41037 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
commented out line with stdout is removed.
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41038 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41055 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41056 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41057 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45527/41058 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
DQM/HcalTasks/plugins/RawTask.cc
Outdated
@@ -232,7 +232,7 @@ RawTask::RawTask(edm::ParameterSet const& ps) | |||
// a comment below is left on purpose! | |||
//_cBadQualityvsBX.fill(bx, creport->badQualityDigis()); | |||
int Nbadq = creport->badQualityDigis(); | |||
if (lumiCache->EvtCntLS == 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
DQM/HcalTasks/plugins/RawTask.cc
Outdated
@@ -414,7 +414,7 @@ std::shared_ptr<hcaldqm::Cache> RawTask::globalBeginLuminosityBlock(edm::Luminos | |||
for (uint32_t iflag = 0; iflag < _vflags.size(); iflag++) | |||
_cSummaryvsLS_FED.setBinContent(eid, _currentLS, int(iflag), int(flag::fNCDAQ)); | |||
_cSummaryvsLS.setBinContent(eid, _currentLS, int(flag::fNCDAQ)); | |||
if (!hcaldqm::utilities::isFEDHO(eid) && fed != 1136) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This PR is closed. A new PR (#45571 ) is opened. As the the current one (45527) was rejecting the updates I was trying to do. |
PR description: