Add specialisations of make_device_view with a Queue argument

[fwyzard]

PR description:

Add specialisations of make_device_view with a Queue argument instead of a Device.

These functions are only for convenience: their behaviour is identical to those taking a Device.

PR validation:

None.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45572/41068

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45572/41069

[cmsbuild]

Pull request #45572 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.

[fwyzard]

please test

[fwyzard]

@makortel this seems to be useful to reduce the calls to alpaka::getDev(queue).
However, it has to be clear to the users that

make_device_view(queue, ...);

is just a shorthand for

make_device_view(alpaka::getDev(queue), ...);

and does not introduce any asynchronous behaviour.

Do you think this is OK, or potentially too confusing ?

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency ClangBuild
Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75d89d/40655/summary.html
COMMIT: 75cd6ac
CMSSW: CMSSW_14_1_X_2024-07-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45572/40655/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/AlpakaWrapper/src/alpaka/HeterogeneousTestAlpakaWrapperROCmAsync/libHeterogeneousTestAlpakaWrapperROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/TrackingRecHitSoA/test/Hits_testROCmAsync/libHits_testROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/DataFormats/TrackingRecHitSoA/test/Hits_testROCmAsync/libHits_testROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/DataFormats/TrackingRecHitSoA/test/Hits_testROCmAsync/libHits_testROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1864: tmp/el8_amd64_gcc12/src/DataFormats/TrackingRecHitSoA/test/Hits_testROCmAsync/libHits_testROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc12/src/DataFormats/SiPixelClusterSoA/test/Clusters_testROCmAsync/libClusters_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/SiPixelDigiSoA/test/DigiErrors_testROCmAsync/libDigiErrors_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/TrackSoA/test/TrackSoAHeterogeneousAlpaka_testROCmAsync/libTrackSoAHeterogeneousAlpaka_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/DataFormats/VertexSoA/test/ZVertexSoA_testROCmAsync/libZVertexSoA_testROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/RecoLocalCalo/HcalRecProducers/plugins/RecoLocalCaloHcalRecProducersPluginsPortableROCmAsync/libRecoLocalCaloHcalRecProducersPluginsPortableROCmAsync_rocm.a to productstore area:


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoLocalCalo/EcalRecProducers
>> Entering Package RecoLocalCalo/HGCalRecProducers
>> Entering Package RecoLocalTracker/SiPixelClusterizer
>> Entering Package RecoTracker/PixelSeeding
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-07-28-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-07-28-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package DataFormats/TrackingRecHitSoA
Entering library rule at DataFormats/TrackingRecHitSoA
>> Compiling  src/DataFormats/TrackingRecHitSoA/src/classes.cc


[makortel]

Do you think this is OK, or potentially too confusing ?

Hmm. On a quick thought I think the potential for misunderstanding is certainly there. I need to digest a bit more to reach a conclusion whether I'd think it would be too confusing or not. In any case documenting the behavior could help.

One possible direction to think about would be to add e.g. async postfix to all functions that may incur asynchronous behavior on some backend(s).

[cmsbuild]

Pull request #45572 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.

[fwyzard]

Updated the documentation and rebased on top of a more recent release.

[fwyzard]

please test

[fwyzard]

+heterogeneous

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75d89d/41478/summary.html
COMMIT: 0e26cb2
CMSSW: CMSSW_14_2_X_2024-09-11-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45572/41478/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 172 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3437830
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3437804
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially removed 36 lines from the logs
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53003
• DQMHistoTests: Total failures: 945
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 52058
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[fwyzard]

@cms-sw/upgrade-l2 could you sign this, please ?

Alternatively, @cms-sw/orp-l2 could you bypass the upgrade signature and merge this ?
It's now been pending for two weeks.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1