Decrease error threshold for BadCapIDThreshold QTest

[nothingface0]

PR description:

As discussed with @DennRoy, This PR decreases the error threshold of the Hcal BadCapIDThreshold QTest, i.e., makes the test more tolerant to errors, allowing the up to any 3 bins to fail the test for the whole plot (which translates to ~99.9% error threshold for 60x42 bins that the plot contains).

A backport will also be created, to patch the DQM production CMSSW deployment.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45602/41095

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/HcalTasks/data/HcalQualityTests.xml modified in PR(s): HCAL DQM Online Histogram for Bad Quality Events #45571

[cmsbuild]

A new Pull Request was created by @nothingface0 for master.

It involves the following packages:

• DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[DryRun]

Thanks for preparing the PR! I have one request: the tuned threshold is only valid for the 60*42 bin histogram, "Hcal/DigiTask/CapID/CapID_BadvsLSmod60", but the LINK wildcard also matches "Hcal/DigiTask/CapID/CapID_BadvsLS" (4000*42 bins; the mod60 histogram was created so that the alarm condition goes away after 60 LSes and stops sounding the alarm). The test should only be run on the former histogram, so the wildcard should be changed to *CapID_BadvsLSmod60*.

[nothingface0]

Thanks for preparing the PR! I have one request: the tuned threshold is only valid for the 6042 bin histogram, "Hcal/DigiTask/CapID/CapID_BadvsLSmod60", but the LINK wildcard also matches "Hcal/DigiTask/CapID/CapID_BadvsLS" (400042 bins; the mod60 histogram was created so that the alarm condition goes away after 60 LSes and stops sounding the alarm). The test should only be run on the former histogram, so the wildcard should be changed to *CapID_BadvsLSmod60*.

Thanks for the catch, I updated the PR

Edit: I wonder if the LINK should still include the Hcal/DigiTask/CapID prefix?
Edit2: After testing, it seems it worked without it :)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45602/41115

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/HcalTasks/data/HcalQualityTests.xml modified in PR(s): HCAL DQM Online Histogram for Bad Quality Events #45571

[cmsbuild]

Pull request #45602 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45602/41201

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/HcalTasks/data/HcalQualityTests.xml modified in PR(s): HCAL DQM Online Histogram for Bad Quality Events #45571

[cmsbuild]

Pull request #45602 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[tjavaid]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6560b/40827/summary.html
COMMIT: 6e1f4e5
CMSSW: CMSSW_14_1_X_2024-08-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45602/40827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 94 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423977
• DQMHistoTests: Total failures: 2463
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421494
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[nothingface0]

Closing in favor of #45571