Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another apptainer workaround [13_2_X] #45710

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kpedro88
Copy link
Contributor

backport of #45652

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2024

A new Pull Request was created by @kpedro88 for CMSSW_13_2_X.

It involves the following packages:

  • HeterogeneousCore/SonicTriton (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @riga, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2024

cms-bot internal usage

@kpedro88
Copy link
Contributor Author

test parameters
workflows = 10804.31

@kpedro88
Copy link
Contributor Author

please test

@makortel
Copy link
Contributor

Thanks @kpedro88. I see we'd need the backport also in

  • 13_3_X
  • 13_1_X
  • 13_0_X
  • 12_6_X
  • 12_4_X

Although we could discuss if some of these earlier release cycles, e.g. those below, could be dropped

  • 13_3_X: latest release 13_3_3 built on 2024-02-21 (although there are commits in 13_3_X branch after that release)
  • 12_6_X: latest release 12_6_5 built on 2023-06-07 (although there are commits in 12_6_X branch after that release)

Assuming 13_2_X and 13_1_X release cycles would still need to be kept, maybe we could consider stopping slc7 builds for them? At this point I'd expect the probability to have do IgProf memory profiling on them to be negligible.

Maybe something we could discuss in the ORP next week? @cms-sw/orp-l2 @smuzaffar

@smuzaffar
Copy link
Contributor

Maybe something we could discuss in the ORP next week? @cms-sw/orp-l2 @smuzaffar

sounds good.
@kpedro88 , isn't this already fixed for apptainer 1.3.2 apptainer/apptainer#2220 , apptainer/apptainer#2234 ?

@kpedro88
Copy link
Contributor Author

It's supposed to be fixed, but we are still encountering problems with it. Apptainer no longer wants to support sl7, so I think we just have to rely on ourselves at this point. I am preparing all of the possible backports and will submit them (before going on vacation for several weeks), and then core/ORP can decide which ones to merge.

@kpedro88
Copy link
Contributor Author

#45719
#45720
#45721
#45722
#45723

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b77d0b/40973/summary.html
COMMIT: 1071497
CMSSW: CMSSW_13_2_X_2024-08-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45710/40973/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3301436
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3301399
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3dd9b7b into cms-sw:CMSSW_13_2_X Aug 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants