-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed CLCT sorting in CSC TP emulator and synchronize the config to the Point-5 data-taking settings #45829
Fixed CLCT sorting in CSC TP emulator and synchronize the config to the Point-5 data-taking settings #45829
Conversation
2. update the configuration parameter to synchronize with the setting for data-taking at P5
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45829/41569 |
A new Pull Request was created by @tahuang1991 for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test |
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
We did test the agreement between OTMB firmware for CSC trigger and CSC TP emulator by injecting simulated muons into OTMB, and finally with these changes and bugfixed firmware, we can achieve a perfect agreement.
Yumeng@yumeng111 presented the results on CSC weekly meeting:
https://indico.cern.ch/event/1450065/contributions/6105639/attachments/2917647/5120368/otmb_cscmeeting.pdf