-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase threshold of max number of pixel clusters for cosmic tracking #46283
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46283/42106 |
A new Pull Request was created by @sroychow for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@@ -39,7 +39,7 @@ def makeSimpleCosmicSeedLayers(*layers): | |||
MaxNumberOfStripClusters = cms.uint32(300), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
casually looking in the online DQM configuration for the strip client, I noticed:
cmssw/DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py
Lines 271 to 272 in 1e14eab
process.simpleCosmicBONSeeds.ClusterCheckPSet.MaxNumberOfStripClusters = 450 | |
process.combinatorialcosmicseedfinderP5.MaxNumberOfStripClusters = 450 |
perhaps it should be considered in the offline reconstruction as well.
PR description:
The rate of cosmic tracks have dropped since ERA G, see latest slides. After performing several tests, Tracker DPG concluded that it was related to the cut that is imposed for number of max. pixel clusters per event in Cosmic tracking, see slides. The average number of clusters in pixel has steadily increased and reaching
300
(default value till now) is roughly correlated in time with the rate drop. We are increasing the threshold to1000
in the configs for Cosmic tracking.If this PR is a backport please specify the original PR and why you need to backport that PR.
Not a backport. Backport will be done for 14_0_X.