Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0] Remove unused L1TCaloSummary DQM sequences causing issues with HCAL. #46490

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

aloeliger
Copy link
Contributor

Backport of #46482

PR description:

Taken from original:

This PR removes two unused sequences in the CICADA DQM that were potentially causing duplicate TPs seen in HCAL tests. No DQM changes are expected as a result of this change.

Also changes Calo Summary DQM configuration to use GT digis instead of test crate digis, which is more correct.

PR validation:

Sequence has been confirmed to work in failing workflows without crashing. HCAL reports this fixes the issue.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This backport is required for 14_0 for MC production with corrected DQM

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2024

A new Pull Request was created by @aloeliger for CMSSW_14_0_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2024

cms-bot internal usage

@aloeliger aloeliger changed the title Cicadadqm hcal fix 14 0 [14_0] Remove unused L1TCaloSummary DQM sequences causing issues with HCAL. Oct 23, 2024
@cmsbuild
Copy link
Contributor

Pull request #46490 was updated. @aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b70a65/42367/summary.html
COMMIT: e812675
CMSSW: CMSSW_14_0_X_2024-10-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46490/42367/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+dqm

@aloeliger
Copy link
Contributor Author

+l1

@aloeliger
Copy link
Contributor Author

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@vlimant
Copy link
Contributor

vlimant commented Oct 28, 2024

urgent

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit adb8a14 into cms-sw:CMSSW_14_0_X Oct 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants