Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix InputTag in SimL1EmulatorRepack_uGT_cff.py #46597

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 4, 2024

PR description:

While trying to run the following script [1] in CMSSW_14_2_X I got the following error:

----- Begin Fatal Exception 04-Nov-2024 15:06:01 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named hlt.py
Exception Message:
 unknown python problem occurred.
TypeError: CICADAScoreInputTag does not already exist, so it can only be set to a CMS python configuration type

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Mixins.py(319): __raiseBadSetAttr
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Mixins.py(244): __addParameter
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Mixins.py(285): __setattr__
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/Configuration/StandardSequences/python/SimL1EmulatorRepack_uGT_cff.py(33): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/FWCore/ParameterSet/python/Config.py(762): load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-11-03-0000/src/HLTrigger/Configuration/python/CustomConfigs.py(178): L1REPACK
  hlt.py(31207): <module>

----- End Fatal Exception -------------------------------------------------

This apparently is caused by PR #45826.
This PR tries to fix the issue.

PR validation:

Run the script in CMSSW_14_2_X_2024-11-03-0000 + this PR and the crash is overcome.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not needed as #45826 was not backported.


[1]

Click me
#!/bin/bash -ex

voms-proxy-init -voms cms

hltGetConfiguration /dev/CMSSW_14_1_0/HIon/V42 \
		    --max-events 10 \
		    --no-prescale \
		    --no-output \
		    --data \
		    --input /store/hidata/HIRun2023A/HIZeroBias0/RAW/v1/000/375/703/00000/03000cf7-c12e-467f-9388-8d106e0ec320.root \
		    --globaltag 141X_dataRun3_HLT_v1 \
		    --eras Run3 \
		    --l1-emulator uGT --l1 L1Menu_CollisionsHeavyIons2024_v1_0_5_xml \
		    --customise HLTrigger/Configuration/CustomConfigs.customiseL1THLTforHIonRepackedRAW --open > hlt.py

cmsRun hlt.py >& hlt.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

cms-bot internal usage

@mmusich mmusich mentioned this pull request Nov 4, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Nov 4, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 4, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02aae7/42582/summary.html
COMMIT: 0068f5f
CMSSW: CMSSW_14_2_X_2024-11-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46597/42582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 75 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569567
  • DQMHistoTests: Total failures: 406
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3569141
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Nov 5, 2024

urgent

  • cannot run L1T emulation in 14.2.X because of this

@cmsbuild cmsbuild added the urgent label Nov 5, 2024
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ad33fbe into cms-sw:master Nov 6, 2024
11 checks passed
@mmusich mmusich deleted the mm_fix_SimL1EmulatorRepack_uGT_cff branch November 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants