Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lumisection Ouputs for das-up-to-nevents.py #46625

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Nov 7, 2024

PR description:

This PR proposes:

  • extra 100k golden data wfs;
  • add an option to das-up-to-nevents.py to dump the json of runs+lumisections for the selected files.
  • to use this option for all the golden workflows (this is needed to properly handle the wfs when submitting with the RelVal machine);
  • a fix for the issue renaming them to RunPark2{Muon|Electron}*. The golden data wfs using ParkingDouble{Muon|Electron}* .

PR validation:

Golden wfs, e.g. 2024.100005, run.

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 7, 2024
@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46625/42529

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c7acb/42654/summary.html
COMMIT: 710330f
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46625/42654/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46625/42533

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

Pull request #46625 was updated. @AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+1

Size: This PR adds an extra 84KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c7acb/42664/summary.html
COMMIT: 2a6b872
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46625/42664/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

AdrianoDee commented Nov 7, 2024 via email

@Moanwar
Copy link
Contributor

Moanwar commented Nov 8, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 51ce6f2 into cms-sw:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants