Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx360H Change names from 2026 to Run4 in several scripts of Geometry/Hcal* and Geometry/HGCal* #46626

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 7, 2024

PR description:

Change names from 2026 to Run4 in several scripts of Geometry/Hcal* and Geometry/HGCal*

PR validation:

Tested by running the scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 7, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)
  • Geometry/HcalCommonData (geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1dd1d/42660/summary.html
COMMIT: de0a907
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46626/42660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Nov 9, 2024

+1

@bsunanda
Copy link
Contributor Author

@subirsarkar please approve this

@bsunanda
Copy link
Contributor Author

@Moanwar Please approve this PR

@subirsarkar
Copy link

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6f54fc2 into cms-sw:master Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants