Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge] Fix for asneeded IBs, force link pythia6/lhapdf libs #46665

Closed
wants to merge 2 commits into from
Closed

[Do not merge] Fix for asneeded IBs, force link pythia6/lhapdf libs #46665

wants to merge 2 commits into from

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 11, 2024 •
edited
Loading

Some Relvals are failing in CMSSW_14_2_ASNEEDED_X IBs. Running these relfals locally print error like [a]. This PR makes sure that LHAPDF/pythia6 libs are linked and loaded at runtime. These libs provide the PDFSET symbol.

explicitly linking the Pyquen/Hydjet/Pythia6 allowed to run all the failing workflows

1143.201_HydjetQ_B12_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:26:24 2024-date Tue Nov 12 11:23:03 2024; exit: 0 0 0 0
143.202_HydjetQ_MinBias_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Tue Nov 12 11:26:27 2024-date Tue Nov 12 11:23:03 2024; exit: 0 0 0 0 0
148.0_HydjetQ_MinBias_XeXe_5442GeV_2017 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:26:20 2024-date Tue Nov 12 11:23:04 2024; exit: 0 0 0 0
43.201_HydjetQ_B12_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:26:24 2024-date Tue Nov 12 11:23:03 2024; exit: 0 0 0 0
331.0_Pyquen_DiJet_pt80to120_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:31:37 2024-date Tue Nov 12 11:26:43 2024; exit: 0 0 0 0
332.0_Pyquen_ZeemumuJets_pt10_5362GeV_2024 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 12 11:31:21 2024-date Tue Nov 12 11:26:47 2024; exit: 0 0 0 0
574.0_HydjetQ_B12_5020GeV_2018_ExtGen Step0-PASSED Step1-PASSED  - time date Tue Nov 12 11:27:26 2024-date Tue Nov 12 11:26:51 2024; exit: 0 0
577.0_Pyquen_ZeemumuJets_pt10_2760GeV_ExtGen Step0-PASSED Step1-PASSED  - time date Tue Nov 12 11:27:20 2024-date Tue Nov 12 11:26:54 2024; exit: 0 0
29 29 27 26 12 3 tests passed, 0 0 0 0 0 0 failed

[a]

1****************** PYINIT: initialization of PYTHIA routines *****************
 Error: you did not link PDFLIB correctly.
 Dummy routine PDFSET in PYTHIA file called instead.
 Execution stopped!

     PYSTOP called with code:    5

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 11, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2024 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • workflows = 132.0,143.201,143.202,148.0,158.0,159.0,159.02,159.03,160.0,160.02,160.03,160.501,161.0,161.02,161.03,300.0,301.0,302.0,310.0,311.0,312.0,320.0,321.0,322.0,330.0,331.0,332.0,574.0,577.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46665/42592

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • GeneratorInterface/Pythia6Interface (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_2_ASNEEDED_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42745/summary.html
COMMIT: 5295f9d
CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46665/42745/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42745/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42745/git-merge-result

RelVals

  • 312.0A fatal system signal has occurred: segmentation violation
  • 148.0A fatal system signal has occurred: segmentation violation
  • 158.0A fatal system signal has occurred: segmentation violation
Expand to see more relval errors ...

@smuzaffar
Copy link
Contributor Author

ok, this change fixed the workflow 132.0 , looks like other generator interface also need such a change e.g. workflow 312.0 is failing as GeneratorInterface/PyquenInterface is missing to link pdfset

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_2_ASNEEDED_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46665/42600

@cmsbuild
Copy link
Contributor

Pull request #46665 was updated. @bbilin, @lviliani, @menglu21, @mkirsano can you please check and sign again.

@smuzaffar smuzaffar changed the title Do not merge] Fix for asneeded IBs, force link pythia6/lhapdf libs [Do not merge] Fix for asneeded IBs, force link pythia6/lhapdf libs Nov 12, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42757/summary.html
COMMIT: 066b0ea
CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46665/42757/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42757/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7a81/42757/git-merge-result

Comparison Summary

Summary:

@smuzaffar smuzaffar mentioned this pull request Nov 12, 2024
Closed
@smuzaffar smuzaffar closed this Nov 13, 2024
@smuzaffar smuzaffar deleted the fix-as-needed-pythia6 branch November 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved generators-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild