Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIM] Fixed compilation warning with the new Geant4 11.3 #46675

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 12, 2024

PR description:

There is the compilation warning with the new Geant4 11.3. This fix is also useful for previous Geant4 version. No change in any WF is expected.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch for master.

It involves the following packages:

  • SimG4Core/Geometry (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc8cf7/42761/summary.html
COMMIT: 60a181e
CMSSW: CMSSW_14_2_X_2024-11-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46675/42761/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor Author

civanch commented Nov 12, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor Author

civanch commented Nov 13, 2024

urgent

@civanch
Copy link
Contributor Author

civanch commented Nov 13, 2024

@antoniovilela , @mandrenguyen , this PR is very simple but is needed urgently for testing of the new Geant4.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17ed47a into cms-sw:master Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants