[14_1_X] Fix maxHitsInModule for SiPixelRecHitFromSoAAlpaka

[AdrianoDee]

PR description:

Backport of #46686 for HIon data taking.

Solves #46656

[cmsbuild]

A new Pull Request was created by @AdrianoDee for CMSSW_14_1_X.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix maxHitsInModule for SiPixelRecHitFromSoAAlpaka #46686

[cmsbuild]

cms-bot internal usage

[mmusich]

enable gpu

[AdrianoDee]

test parameters:

• relval_gpu_opt = -w upgrade
• workflow_gpu = 14949.402, 17434.402

[AdrianoDee]

please test

[mmusich]

urgent

[AdrianoDee]

please abort

[AdrianoDee]

test parameters:

• relval_opts_gpu = -w upgrade
• workflow_gpu = 14949.402, 17434.402

[AdrianoDee]

please test

[AdrianoDee]

backport of #46686

[mmusich]

type bug-fix

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b86f3/42790/summary.html
COMMIT: 9b8e10f
CMSSW: CMSSW_14_1_X_2024-11-12-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46687/42790/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

ValueError: Undefined workflows: 17434.402

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3565669
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565641
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 199 log files, 169 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

test parameters:

• relval_opts_gpu = -w upgrade
• workflow_gpu = 14949.402, 13034.402

[AdrianoDee]

please test

[mmusich]

as #45887 was not backported, I guess the tests should pass here?

[AdrianoDee]

Yep, I tested an HIN *.402 wf offline and it worked. Let's see the outcome of the tests.

[mmusich]

I guess the tests should pass here?

in a plain CMSSW_14_1_X_2024-11-12-2300

runTheMatrix.py --what gpu,upgrade -l 14949.402 -t 4

[...]
 
14949.402_HydjetQMinBias_5020GeV+2022HI_Patatrack_PixelOnlyAlpaka Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Nov 13 16:40:08 2024-date Wed Nov 13 15:56:44 2024; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b86f3/42808/summary.html
COMMIT: 9b8e10f
CMSSW: CMSSW_14_1_X_2024-11-13-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46687/42808/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3565669
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565643
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 199 log files, 169 edm output root files, 46 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 25 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 84941
• DQMHistoTests: Total failures: 2486
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 82455
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 32 log files, 40 edm output root files, 9 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will be automatically merged.

[jfernan2]

+1