Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release memory earlier in PFBlockProducer #46712

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Release memory earlier in PFBlockProducer #46712

merged 2 commits into from
Nov 18, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Using an experimental AllocMonitor service showed that PFBlockProducer was holding additional memory between events which was often then resized.

PR validation:

A simple test using step3 of workflow 1330.0 showed that per event memory retention was eliminated.

@Dr15Jones
Release memory in PFBlockAlgo
4448815 
One of the helper plugins was already calling shrink_to_fit after
filling this container so resizes were happening on events
already.
@Dr15Jones
Reduce memory held between events by KDTreeLinkerAlgo
8a23583 
PFBlockProducer was seen to hold additional memory between events
from here.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 15, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46712/42670

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • RecoParticleFlow/PFProducer (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@abbiendi, @ahinzmann, @gkasieczka, @hatakeyamak, @jdolen, @jhgoh, @lgray, @missirol, @mmarionncern, @rappoccio, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-371f2e/42891/summary.html
COMMIT: 8a23583
CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46712/42891/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4c6569e into cms-sw:master Nov 18, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the pfMemRelease branch November 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @jfernan2 @mandrenguyen